Opened 12 years ago

Closed 12 years ago

#8557 closed enhancement (fixed)

is_singular method for projective plane curves

Reported by: cturner Owned by: AlexGhitza
Priority: minor Milestone: sage-4.4
Component: algebraic geometry Keywords:
Cc: cremona Merged in: sage-4.4.alpha1
Authors: Charlie Turner Reviewers: Alex Ghitza
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

It would be useful to have a way of checking whether a projective curve has any singular points. A patch to do this is on its way.

Attachments (2)

trac_8557_is_singular.patch (2.0 KB) - added by cturner 12 years ago.
trac_8557_rebased.patch (2.1 KB) - added by jhpalmieri 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by cturner

comment:1 Changed 12 years ago by cturner

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by AlexGhitza

  • Authors changed from cturner to Charlie Turner
  • Milestone set to sage-4.4
  • Reviewers set to Alex Ghitza
  • Status changed from needs_review to positive_review

Looks good.

We should (more generally) wrap Singular's slocus function which computes the singular locus of an ideal in a multivariate polynomial ring, but that should be a new ticket.

comment:3 Changed 12 years ago by jhpalmieri

  • Status changed from positive_review to needs_work

This doesn't apply cleanly; it apparently conflicts with a patch merged into Sage 4.4.alpha0. Please rebase it against 4.4.alpha0, and we'll try hard to get this into 4.4.alpha1.

comment:4 Changed 12 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

Never mind, I've taken care of it.

comment:5 Changed 12 years ago by jhpalmieri

  • Status changed from needs_review to positive_review

Changed 12 years ago by jhpalmieri

comment:6 Changed 12 years ago by jhpalmieri

  • Merged in set to sage-4.4.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Merged "trac_8557_rebased.patch" into 4.4.alpha1.

Note: See TracTickets for help on using tickets.