Opened 12 years ago
Closed 12 years ago
#8548 closed defect (fixed)
Permutation : a bad error message in hyperoctahedral_double_coset_type
Reported by: | giraudo | Owned by: | sage-combinat |
---|---|---|---|
Priority: | trivial | Milestone: | sage-4.4 |
Component: | combinatorics | Keywords: | |
Cc: | Merged in: | ||
Authors: | Samuele Giraudo | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Obviously, the instructions
pp = Permutation([3, 1, 2]) pp.hyperoctahedral_double_coset_type()
lead to an error because the permutation has an odd size. However, there is an error in the raised error message :
NameError: global name 'p' is not defined
The string should be
ValueError: [3, 1, 2] is a permutation of odd size and has no coset-type
Attachments (1)
Change History (6)
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 12 years ago by
- Status changed from closed to needs_work
- Work issues set to needs review
comment:3 follow-up: ↓ 4 Changed 12 years ago by
- Status changed from needs_work to needs_review
comment:4 in reply to: ↑ 3 Changed 12 years ago by
Hi Samuele,
You're able to fix problems that as not yet in sage ! Impressive :-) See #8420 where the problem should be solve.
For the release manager: please close this as a duplicate.
comment:5 Changed 12 years ago by
- Status changed from needs_review to closed
- Work issues needs review deleted
Close as fixed by #8420.
Note: See
TracTickets for help on using
tickets.
Samuele,
Thanks for catching this problem and submitting a patch! However, you should not close tickets--that is for the release manager. See http://sagemath.org/doc/developer/trac.html for more detail on the process.