#8542 closed defect (fixed)
Pynac should use a function pointer table
Reported by: | mhansen | Owned by: | burcin |
---|---|---|---|
Priority: | major | Milestone: | sage-4.4.3 |
Component: | porting: Cygwin | Keywords: | pynac |
Cc: | Merged in: | sage-4.4.3.alpha1 | |
Authors: | Mike Hansen | Reviewers: | Burcin Erocal |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
It also needs to be configured to build a DLL in Cygwin. There are some automake macros that will help with this.
Attachments (1)
Change History (16)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Shall I include the diff above in the next Pynac release?
I could have done this for the version I just released (#8644) if I had known earlier...
comment:3 Changed 11 years ago by
No, not quite yet. Basically, we'll also have the stuff to autotools to detect where Python is, etc.
comment:4 Changed 11 years ago by
- Description modified (diff)
- Summary changed from Pynac does not build a DLL on Cygwin to Pynac should use a function pointer table
Changed 11 years ago by
comment:5 Changed 11 years ago by
- Description modified (diff)
- Milestone set to sage-4.4.2
I'll post the spkg shortly.
comment:6 follow-up: ↓ 7 Changed 11 years ago by
- Description modified (diff)
There's an spkg at http://sage.math.washington.edu/home/mhansen/pynac-0.13.spkg, but it needs to have changes committed / SPKG.txt made / version number updated.
comment:7 in reply to: ↑ 6 Changed 11 years ago by
Replying to mhansen:
There's an spkg at http://sage.math.washington.edu/home/mhansen/pynac-0.13.spkg, but it needs to have changes committed / SPKG.txt made / version number updated.
I'll take a look at these and merge #8651 as well.
comment:8 Changed 11 years ago by
- Keywords pynac added
- Owner changed from tbd to burcin
- Reviewers set to Burcin Erocal
Both patches, for pynac and Sage, look good to me.
Building the new pynac package fails with the following error:
... /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.4/../../../../x86_64-pc-linux-gnu/bin/ld: /home/burcin/sage/sage-4.4.1.alpha2-patched/local/lib/python2.6/config/libpython2.6.a(abstract.o): relocation R_X86_64_32 against `a local symbol' can not be used when making a shared object; recompile with -fPIC /home/burcin/sage/sage-4.4.1.alpha2-patched/local/lib/python2.6/config/libpython2.6.a: could not read symbols: Bad value collect2: ld returned 1 exit status make[2]: *** [libpynac.la] Error 1 make[2]: Leaving directory `/home/burcin/sage/sage-4.4.1.alpha2-patched/spkg/build/pynac-0.1.13/src/ginac' ...
Do we have a python package that uses -fPIC
?
comment:9 Changed 11 years ago by
Does this work for you http://sage.math.washington.edu/home/mhansen/python-2.6.4.p8.spkg ?
comment:10 Changed 11 years ago by
comment:11 Changed 11 years ago by
I'll test the Python spkg on other systems.
comment:12 Changed 11 years ago by
- Status changed from new to needs_review
New pynac package containing Mike's function table and autoconf patches is available at #8903 or directly from:
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.2.0.spkg
The package also requires patches from #8651, #8775 and #8688.
comment:13 Changed 11 years ago by
- Status changed from needs_review to positive_review
Great work Mike! Cygwin, here we come!
comment:14 Changed 11 years ago by
- Merged in set to 4.4.3.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:15 Changed 11 years ago by
- Merged in changed from 4.4.3.alpha1 to sage-4.4.3.alpha1
It basically comes down to adding the following changes
and fixing the fallout by making sure that Python gets linked in.