Opened 12 years ago

Closed 12 years ago

#8509 closed defect (fixed)

Ilegal 'grep -o' causes problems installing optional packages on Solaris

Reported by: drkirkby Owned by: drkirkby
Priority: major Milestone: sage-4.4
Component: porting: Solaris Keywords:
Cc: jhpalmieri Merged in: sage-4.4.alpha0
Authors: David Kirkby, John Palmieri Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Hardware

  • Sun Blade 1000
  • 2 x 900 MHz UltraSPARC III+ CPUs.
  • 2 GB RAM

Software

  • Solaris 10 03/2005 (the first release)
  • Sage 4.3.4.alpha1 (The first Sage release to build and pass all doctests on Solaris)

The problem

Despite the fact that Sage builds and pass all doctests (including the long ones), installing optional packages is problematic, as it would appear something is calling 'grep' with the '-o' option which is not POSIX compatible

http://www.opengroup.org/onlinepubs/9699919799/utilities/grep.html

This causes the problems below:

sage: for X in optional_packages()[1]:  install_package(X)
....: 
Force installing ace-5.0.p0
Calling sage-spkg on ace-5.0.p0
Warning: Attempted to overwrite SAGE_ROOT environment variable
ace-5.0.p0
Machine:
SunOS redstart 5.10 Generic sun4u sparc SUNW,Sun-Blade-1000
Deleting directories from past builds of previous/current versions of ace-5.0.p0
/export/home/drkirkby/sage-4.3.4.alpha1/local/bin/sage-spkg: file ace-5.0.p0 does not exist
Attempting to download it.
grep: illegal option -- o
Usage: grep -hblcnsviw pattern file . . .
Searching for latest version of ace-5.0.p0
Could not find a version for ace-5.0.p0.

Force installing biopython-1.53.p0
Calling sage-spkg on biopython-1.53.p0
Warning: Attempted to overwrite SAGE_ROOT environment variable
biopython-1.53.p0
Machine:
SunOS redstart 5.10 Generic sun4u sparc SUNW,Sun-Blade-1000
Deleting directories from past builds of previous/current versions of biopython-1.53.p0
/export/home/drkirkby/sage-4.3.4.alpha1/local/bin/sage-spkg: file biopython-1.53.p0 does not exist
Attempting to download it.
grep: illegal option -- o
Usage: grep -hblcnsviw pattern file . . .
Searching for latest version of biopython-1.53.p0
Could not find a version for biopython-1.53.p0.

Attachments (2)

sage-spkg (12.1 KB) - added by drkirkby 12 years ago.
Revised sage-spkg removing the -o option
sage-spkg.patch (576 bytes) - added by drkirkby 12 years ago.
Mercurial patch (replaces the earlier one, which was just from 'diff')

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by drkirkby

Revised sage-spkg removing the -o option

comment:1 Changed 12 years ago by drkirkby

  • Authors set to David Kirkby, John Palmieri
  • Cc jhpalmieri added
  • Status changed from new to needs_review

Thanks to John Palmieri who suggested this solution, which does work.

comment:2 Changed 12 years ago by jhpalmieri

sage-spkg should be under revision control: either run Mercurial from the directory SAGE_ROOT/local/bin, or while running sage, use "hg_scripts" (instead of "hg_sage").

comment:3 follow-up: Changed 12 years ago by drkirkby

Oops, my mistake. I was not aware of that. I'm attaching a Mercurial patch

Changed 12 years ago by drkirkby

Mercurial patch (replaces the earlier one, which was just from 'diff')

comment:4 in reply to: ↑ 3 ; follow-up: Changed 12 years ago by dimpase

  • Status changed from needs_review to needs_work

Replying to drkirkby:

Oops, my mistake. I was not aware of that. I'm attaching a Mercurial patch

Dave, $SAGE_ROOT/local/bin is not under hg. You should create a patch for the corresponding source place, i.e. for a script in sage_scripts-4.3.4.alpha1.spkg

That's the only way to make it into the release, AFAIK.

comment:5 in reply to: ↑ 4 Changed 12 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

Replying to dimpase:

Replying to drkirkby:

Oops, my mistake. I was not aware of that. I'm attaching a Mercurial patch

Dave, $SAGE_ROOT/local/bin is not under hg.

It is, actually; as I said before, it's the "scripts" repository discussed in the Sage developer's guide.

comment:6 Changed 12 years ago by drkirkby

I created that while running Mercurial from $SAGE_ROOT/local/bin which is what you said John. I did not use 'hg_scripts'. (I tend to prefer using 'hg' as it means one can apply patches to Sage before even building it.

I'll try use 'hg_scripts' later, but for now I need to do something more pressing. I'm in the middle of decorating and my wife will be coming home in a few days expecting to see it done. Like all these things, it takes a lot longer than one thinks. So this patch is going to have to wait a bit.

If anyone want to replace my patch with one more suitable, feel free, but otherwise I'll sort this out when I've got the more important jobs out of the way.

Dave

comment:7 Changed 12 years ago by jhpalmieri

Running "hg_scripts" from within Sage is, as far as I know, equivalent to running "hg" or "sage -hg" from the command line while in the directory $SAGE_ROOT/local/bin. So you don't need to produce a new patch.

comment:8 follow-up: Changed 12 years ago by drkirkby

Thank you John.

That makes sense. I think I just need to put a note for the release manager to sage what repository it goes in, but apart from that, I think it will be ok.

All we need now is someone to review it! Since it was your idea, and I tested and wrote it, then neither of us can review it.

Dave

comment:9 Changed 12 years ago by drkirkby

Note to the release manager - this patch is for the sage shell scripts repository.

comment:10 in reply to: ↑ 8 Changed 12 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to drkirkby:

All we need now is someone to review it! Since it was your idea, and I tested and wrote it, then neither of us can review it.

Works on t2 (and on a Linux install, just to check it doesn't break anything badly). So, thumbs up!

comment:11 Changed 12 years ago by jhpalmieri

  • Merged in set to sage-4.4.alpha0
  • Resolution set to fixed
  • Reviewers set to Dmitrii Pasechnik
  • Status changed from positive_review to closed

Merged "sage-spkg.patch" into 4.4.alpha0.

Note: See TracTickets for help on using tickets.