Changes between Version 21 and Version 25 of Ticket #8473


Ignore:
Timestamp:
08/01/11 21:11:49 (9 years ago)
Author:
kcrisman
Comment:

This needs to be (slightly) rebased for #10652. I can't tell immediately whether the extra filetypes allowed there need any other changes to this patch - my sense is probably not? Anyway, that shouldn't be too hard.

Yeah, the problem on the computer where this doesn't work quite right is probably the same as yours - because I also have a nonstandard browser (well, Firefox) as default there. Switching the default browser to Safari removes the problem.

I really want to give this positive review so that I can review #11026, #10556, and #10555, but it seems like it's not great that one would have to use Safari on Mac for this to work properly (and who knows on other systems where I haven't tested this?).

What's particularly odd is that sage-open (in the scripts directory) is getting the correct browser for me, as far as I can tell, in either case (Safari or FF). But the way sage/misc/viewer.py operates is a little mysterious - sage-native-execute shouldn't have to run sage-open on OS X.

Any thoughts? I'm sorry for the delay in reviewing this, I was busy with Cygwin and running the workshop in my Sage time this summer.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8473

    • Property Status changed from needs_review to needs_work
  • Ticket #8473 – Description

    v21 v25  
    1111would be a very good step in this direction.
    1212
    13 Depends on #693; apply only [attachment:trac_8473-sagenb.2.patch]
     13Depends on #693; apply only [attachment:trac_8473-sagenb.2.patch] to the notebook repository.
    1414
    1515Syntax is