#8407 closed enhancement (fixed)
more practical construction of word paths
Reported by: | slabbe | Owned by: | slabbe |
---|---|---|---|
Priority: | major | Milestone: | sage-4.4.1 |
Component: | combinatorics | Keywords: | |
Cc: | abmasse | Merged in: | sage-4.4.1.alpha2 |
Authors: | Sébastien Labbé | Reviewers: | Alexandre Blondin Massé, Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Improve the construction of word path parent : creation from 2*n letters and n vectors now works (it takes the opposite of vectors).
Attachments (1)
Change History (10)
comment:1 Changed 7 years ago by
- Cc abmasse added
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
comment:3 Changed 7 years ago by
- Status changed from needs_review to needs_work
Just noticed I should have set this ticket to "needs work". Done.
comment:4 Changed 7 years ago by
- Description modified (diff)
- Summary changed from word paths isometries + improve construction to more practical construction of word paths
I removed one of the objectives of the ticket related to isometries. Indeed, I need this function for another problem so I think its use will be more understood in context. So that is why I removed this part from this ticket. I will create a new ticket for it soon.
Changed 7 years ago by
comment:5 Changed 7 years ago by
- Status changed from needs_work to needs_review
comment:6 Changed 7 years ago by
- Status changed from needs_review to positive_review
Applies fine, does it job :-)
Thank you for your work !
Nathann
comment:7 Changed 7 years ago by
- Merged in set to 4.4.1.alpha2
- Resolution set to fixed
- Status changed from positive_review to closed
comment:8 Changed 7 years ago by
- Reviewers set to Alexandre Blondin Massé, Nathann Cohen
comment:9 Changed 7 years ago by
- Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2
Note: See
TracTickets for help on using
tickets.
These functions are really interesting ! I can't wait to use them. However, here are some comments:
rotate()
andreflects()
(with pertinent parameters) that compute ONE rotated or reflected version of the path instead of all EIGHT at the same time. This wouldn't be too long to do and then your functionisometries()
could call them.reversal
. If I understand it well, it is the word reversal operator, which can be geometrically interpreted as performing a rotation of angle pi (of the path) together with an orientation reversal of the path. It seems more natural to me that the parameterreversal
correspond simply to the orientation reversal rather than to the word reversal.What do you think ?