Opened 11 years ago

Closed 11 years ago

#8352 closed defect (fixed)

twisted-8.2.0.p1 fails to build in Open Solaris x64 as 64 bit even if SAGE64=yes

Reported by: jsp Owned by: drkirkby
Priority: major Milestone: sage-4.3.4
Component: porting Keywords:
Cc: Merged in:
Authors: Jaap Spies Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

twisted builds in 32 bit mode on Open Solaris x64.

A fix is coming up.

Jaap

Attachments (1)

twisted-8.2.0.p2.patch (1.0 KB) - added by jsp 11 years ago.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by jsp

comment:1 Changed 11 years ago by jsp

  • Authors set to Jaap Spies
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by drkirkby

You might want to take a look at #7552 too, as that is an update to the twisted package. There are two tickets both updating twisted. I will put a note on that ticket about this one.

I don't know the best way to handle this. I could give this positive review now (there is nothing wrong with it), but I'm not sure of the most logical way to do about this.

comment:3 Changed 11 years ago by drkirkby

  • Reviewers set to David Kirkby

With no response on how to handle this, I'm giving this positive review. I'll make a note on #7552 that these changes have been reviewed, and that the ticket will have to incorporate your changes.

comment:4 follow-up: Changed 11 years ago by mpatel

The "p2" spkg at #7552 includes the patch.

comment:5 in reply to: ↑ 4 Changed 11 years ago by jsp

Replying to mpatel:

The "p2" spkg at #7552 includes the patch.

Meaning? Does this mean this ticket will be closed?

Jaap

comment:6 Changed 11 years ago by drkirkby

It can't be closed yet (and in any case you should not close it, but leave a message for the release manager to do so) until #7552 is merged.

But looking at #7552, there does seem little reason that can't be reviewed quite easily. It would appear there were some minor issues with exactly how the changes were checked in via Mercurial, but otherwise it would appear that the ticket should be quite easy to review. I need to do something else just now, but I'll take a look at that later today.

I think this will be resolved today.

Dave

comment:7 Changed 11 years ago by drkirkby

  • Status changed from needs_review to needs_info

Note to release manager

I've given #7552, (which is an update of the version of twisted) positive review. That ticket now incorporates these changes, so this ticket does not need incorporating now. I've added Jaap as an author on #7552.

I've stuck this to 'needs info' as really it no longer needs reviewing. I believe it should be closed, but I'm not allowed to do that, so 'needs info' seemed the least confusing.

Dave

comment:8 Changed 11 years ago by mvngu

  • Resolution set to fixed
  • Status changed from needs_info to closed

Close as fixed by #7552.

Note: See TracTickets for help on using tickets.