Opened 11 years ago

Closed 11 years ago

#8351 closed defect (fixed)

ratpoints-2.1.3.p0 fails to build in Open Solaris x64 as 64 bit even if SAGE64=yes

Reported by: jsp Owned by: drkirkby
Priority: major Milestone: sage-4.4.4
Component: porting Keywords:
Cc: Merged in: sage-4.4.4.alpha0
Authors: Jaap Spies Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

ratpoints builds in 32 bit mode on Solaris x64.

A patch is coming up.

Jaap

Attachments (2)

ratpoints-2.1.3.p1.patch (1.7 KB) - added by jsp 11 years ago.
ratpoints-2.1.3.p1+.patch (809 bytes) - added by jsp 11 years ago.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by jsp

comment:1 Changed 11 years ago by jsp

  • Authors set to Jaap Spies
  • Status changed from new to needs_review

A new spkg can be found here:

http://boxen.math.washington.edu/home/jsp/ports/ratpoints-2.1.3.p1.spkg

find_points.o:	ELF 64-bit LSB relocatable AMD64 Version 1
init.o:		ELF 64-bit LSB relocatable AMD64 Version 1
sift.o:		ELF 64-bit LSB relocatable AMD64 Version 1
sturm.o:	ELF 64-bit LSB relocatable AMD64 Version 1

Jaap

comment:2 follow-up: Changed 11 years ago by drkirkby

  • Status changed from needs_review to needs_work

There is a problem with this patch, in that tests for CCFLAG64, not CFLAG64 as others do. So it needs work.

However, there are other problems with ratpoints that I am aware of. It is using the compiler option

-DUSE_SSE 

on SPARC, even though the SPARC processor has no SSE instructions. That does not appear to be a serious issue, but ratpoints has been implicated as the reason the Sage library does not build - see #7867, which is very serious.

It might be better if you leave this one to me to try to sort out, as the SPARC issues are more serious.

Dave

comment:3 in reply to: ↑ 2 Changed 11 years ago by jsp

Replying to drkirkby:

There is a problem with this patch, in that tests for CCFLAG64, not CFLAG64 as others do. So it needs work.

Ok, I can do that though CFLAG64 is not used in this spkg.

However, there are other problems with ratpoints that I am aware of. It is using the compiler option

-DUSE_SSE 

on SPARC, even though the SPARC processor has no SSE instructions. That does not appear to be a serious issue, but ratpoints has been implicated as the reason the Sage library does not build - see #7867, which is very serious.

It might be better if you leave this one to me to try to sort out, as the SPARC issues are more serious.

Yes, please solve the problems on SPARC, but that is certainly an other ticket. Let this spkg work on Open Solaris x64 is the only issue solved with this ticket.

Cheers,

Jaap

Dave

Changed 11 years ago by jsp

comment:4 Changed 11 years ago by jsp

  • Status changed from needs_work to needs_review

comment:5 follow-up: Changed 11 years ago by drkirkby

  • Status changed from needs_review to needs_work

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

I would avoid mentioning Solaris specifically unless it is necessary. In this case it is not.

Dave

comment:6 in reply to: ↑ 5 ; follow-up: Changed 11 years ago by jsp

Replying to drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

I would avoid mentioning Solaris specifically unless it is necessary. In this case it is not.

Please go ahead and make a reviewers patch.

Jaap

Dave

comment:7 in reply to: ↑ 6 ; follow-up: Changed 11 years ago by drkirkby

Replying to jsp:

Replying to drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

I do not consider it nit-picking, for reasons you see below.

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

It is very much a Sage goal. There is every reason to believe a Solaris 10 port will be 64-bit. The only reason the port was first 32-bit is that gcc tends to be less reliable on 64-bit SPARC.

It could even beat the Open Solaris port, though my interest is more in Open Solaris now.

Dave

comment:8 in reply to: ↑ 7 Changed 11 years ago by jsp

Replying to drkirkby:

Replying to jsp:

Replying to drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

I do not consider it nit-picking, for reasons you see below.

I don't see that.

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

It is very much a Sage goal. There is every reason to believe a Solaris 10 port will be 64-bit. The only reason the port was first 32-bit is that gcc tends to be less reliable on 64-bit SPARC.

It could even beat the Open Solaris port, though my interest is more in Open Solaris now.

Please make it possible. My interest is in Open Solaris too. Let's make this possible asap. If you insist on making this ticket the first in a target to make Solaris 10 64 bit work, please go ahead and count me off.

Jaap

Dave

comment:9 Changed 11 years ago by drkirkby

  • Reviewers set to David Kirkby
  • Status changed from needs_work to needs_review

Lets just get this done. It works.

Dave

comment:10 Changed 11 years ago by drkirkby

  • Status changed from needs_review to positive_review

comment:11 Changed 11 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.