Changes between Version 5 and Version 14 of Ticket #8335


Ignore:
Timestamp:
02/08/13 14:40:16 (9 years ago)
Author:
jpflori
Comment:

These patches were quite old and things have moved around since they were written. As a consequence, part of the old patches now apply to different files, that is the case of the NTL GF2E implementation which has been split in a Python and a Cython file.

Some pseudo Conway polys changed so that two doctests now fail (not corrected in the patches cause I did not take the time to think about it, feel free to do it). As these pseudo Conway polynomials are not unique, I'm not sure if the procedure to generate them is deterministic or to which point randomness comes into play and if the failing doctests are just due to some routine called during the generation which may give a different result since the patches were originally written.

Not really sure how to cast restriction on the is_square and squarefree_decomposition methods, nor what I've changed makes sense, I've come up with this quickly, feel free to correct it. The basic problem was that now Sage supports function fields where we have no p-th roots and that raised an AttributeError? when calling is_square which called squarefree_decomposition in some doctests.

The doc now builds ok and looks nice (although I did not have LaTeX on my computer), but may need some revamping. Nonetheless it would be great to get this in quickly.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8335

    • Property Status changed from needs_review to needs_info
    • Property Cc defeo rbeezer added
    • Property Milestone changed from sage-5.7 to sage-5.8
  • Ticket #8335 – Description

    v5 v14  
    1616Also adds methods `any_root` and `squarefree_decomposition` to polynomials over finite fields.
    1717
    18 Depends on #8218, #8332, #7880, #7883, #8333, #8334
     18Depends on #8218, #8332, #7880, #7883, #8333, #8334.
     19
     20__APPLY__
     21
     22*[attachment:trac_8335-pseudo_conway-5.7.b3.patch]
     23*[attachment:trac_8335-finite_field_coerce-5.7.b3.patch]
     24*[attachment:trac_8335-doc-5.7.b3.patch]