#8334 closed enhancement (fixed)
Improvements to residue fields
Reported by: | roed | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6 |
Component: | algebra | Keywords: | |
Cc: | was | Merged in: | sage-4.6.alpha2 |
Authors: | David Roe | Reviewers: | David Loeffler |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Attachments (9)
Change History (42)
Changed 10 years ago by
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
Part of a series:
8218 -> 8332 -> 7880 -> 7883 -> 8333 -> 8334 -> 8335
I tried to make each of these mostly self contained, with doctests passing after every ticket, but I didn't entirely succeed. If you're reviewing one of these tickets, applying later tickets will hopefully fix doctest failures that you're seeing.
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Status changed from needs_review to needs_work
FWIW, testing with this and all the prior patches in the series applied under 4.3.4.rc0 brings up exactly 1 doctest failure, in line 321 of sage/rings/finite_rings/finite_field_givaro.py:
File "/home/masiao/sage-4.3.4.rc0/devel/sage-working/sage/rings/finite_rings/finite_field_ givaro.py", line 321: sage: F81(F9.gen()) Expected: Traceback (most recent call last): ... TypeError: unable to coerce from a finite field other than the prime subfield Got: Traceback (most recent call last): File "/home/masiao/sage-4.3.4.rc0/local/bin/ncadoctest.py", line 1231, in run_one_te st self.run_one_example(test, example, filename, compileflags) File "/home/masiao/sage-4.3.4.rc0/local/bin/sagedoctest.py", line 38, in run_one_exa mple OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/home/masiao/sage-4.3.4.rc0/local/bin/ncadoctest.py", line 1172, in run_one_ex ample compileflags, 1) in test.globs File "<doctest __main__.example_6[49]>", line 1, in <module> F81(F9.gen())###line 321: sage: F81(F9.gen()) File "parent.pyx", line 826, in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:6232) File "parent.pyx", line 1876, in sage.structure.parent.Parent.convert_map_from (sage/structure/parent.c:12773) File "parent.pyx", line 1883, in sage.structure.parent.Parent.discover_convert_map_from (sage/structure/parent.c:12925) File "parent.pyx", line 1740, in sage.structure.parent.Parent.coerce_map_from (sage/structure/parent.c:11546) File "parent.pyx", line 1791, in sage.structure.parent.Parent.discover_coerce_map_from (sage/structure/parent.c:11946) File "parent_old.pyx", line 503, in sage.structure.parent_old.Parent._coerce_map_from_ (sage/structure/parent_old.c:5943) File "/home/masiao/sage-4.3.4.rc0/local/lib/python/site-packages/sage/rings/finite_rings/finite_field_givaro.py", line 350, in _coerce_map_from_ raise NotImplementedError NotImplementedError
comment:4 Changed 10 years ago by
The patch conflicts with #8446, so I've uploaded a rebased version.
comment:5 Changed 9 years ago by
- Status changed from needs_work to needs_review
Apply:
7585_9_1_frac_and_coerce_updates.patch 8334_residue_fields-rebased_for_8446.patch 7585_12_1_fixes.patch.2
comment:6 Changed 9 years ago by
- Status changed from needs_review to needs_work
- Work issues set to conflicts
It doesn't work. On vanilla 4.6.alpha1, if I apply
7883_ideals.patch 7883_fixes.patch 8333_parent_init.patch 8333_finite_fields_to_new_coercion.2.patch 7585_9_1_frac_and_coerce_updates.patch 8334_residue_fields-rebased_for_8446.patch
then the first five apply (with minor fuzz) but the last one is completely knackered, with 23 out of 27 hunks failing. I think the problem is caused by #9343/#9400 which both make extensive changes to residue fields.
Just a general observation: you've managed to virtually guarantee that these patches are impossible to review, because they're all linked together in such a way that they fail doctests unless you apply the whole series. So the effect is a huge patch bomb, which is unappealing to review; hence it sits around for ages, and inevitably bitrots. Please, please, please back-port the doctest fixes etc, so each ticket in the series passes doctests on its own. Otherwise this will really never get merged and all of your hard work writing this excellent code (not to mention the work of those who have attempted to review it) will be for nothing.
comment:7 Changed 9 years ago by
- Description modified (diff)
comment:8 Changed 9 years ago by
- Status changed from needs_work to needs_review
I'm sorry that this has been so difficult to review. I've tended to work in chunks: I just start ripping things apart and changing lots of stuff, and then I need to fix it all; by the time I've managed to make all the doctests pass it's turned into a patch-bomb. I've tried to split things into logically consistent chunks, but it's really frustrating trying to backport fixes. I also really shouldn't be working on Sage right now: I should be working on my thesis, which has nothing to do with this.
I've tried to get these tickets working against 4.6.alpha1 (in particular, I think they should now). If they don't get reviewed, I'll try your approach. In the mean time, the sequence of patches should be
7883_ideals.patch 7883_fixes.patch 8333_parent_init.patch 8333_finite_fields_to_new_coercion.2.patch 7585_9_1_frac_and_coerce_updates.patch 8334_residue_fields-rebased_for_9343.patch 7585_12_1_fixes.2.patch
comment:9 Changed 9 years ago by
- Status changed from needs_review to needs_work
gah. Manual merge doesn't build. Working on it...
comment:10 Changed 9 years ago by
Forgot to delete 4 lines. I'm still building, but the build has progressed past residue_field.pyx
.
comment:11 Changed 9 years ago by
I'm getting weird doctest failures, as if some of the changes in 7883_ideals.patch didn't get applied. Then I switched to my main branch and now Pari segfaults upon sage starting up.
I'm going to install a fresh copy of sage-4.6.alpha1, which will take a few hours, and try to figure out what's going on.
comment:12 Changed 9 years ago by
comment:13 Changed 9 years ago by
sure
comment:14 Changed 9 years ago by
- Status changed from needs_work to needs_review
You now only need to apply one patch.
comment:15 Changed 9 years ago by
All doctests pass for me, though I didn't run -long (it already takes a couple hours on my laptop)
comment:16 Changed 9 years ago by
Sadly this conflicts with the positively-reviewed patch series #9898/#9753/#9764.
I will handle rebasing it past those. You can sit back and relax. Thanks for all your sterling efforts on this particularly frustrating job. I have access to a very fast computer (from Bill Hart's research grant, thanks Bill) which runs long tests in about 10 minutes :-)
comment:17 Changed 9 years ago by
Thanks. That's especially useful since I just broke my mercurial queues trying to switch back to a more finely grained set of patches than 8333_8334_ALL.patch
. Oh well, I'll just tell Mercurial that there are no patches there and both it and sage will be happy.
comment:18 Changed 9 years ago by
- Reviewers set to David Loeffler
- Status changed from needs_review to positive_review
- Work issues conflicts deleted
Right, so I have rebased roed's last patch and uploaded my rebased patch as 8333_8334_ALL-rebased_for_9764.patch
. This patch will apply cleanly to 4.6.alpha1 on top of the folded patch from #7883 and the series #9898/#9753/#9764.
This patch incorporates everything from #8333 as well, so this is the only patch that needs to be applied to close both #8333 and this ticket.
comment:19 Changed 9 years ago by
Yay! Thank you for your work on these patches.
comment:20 follow-up: ↓ 22 Changed 9 years ago by
Incidentally, are you running a 32-bit or a 64-bit machine? I don't have access to any 32-bit boxes. If you have access to a 32-bit machine, it would be great if you could do the following:
- Install #9898/#9753/#9764 and test everything in sage/rings.
- Then install #7883 and the combined patch from this ticket, and do sage/rings again.
- Then install #9359 and repeat.
I'm a little nervous about silly doctest failures coming up from Pari's unpredictable choices of generators of ideals, and this would set my mind at rest a bit :-)
comment:21 Changed 9 years ago by
In fact, I can think of one hashing doctest which will fail on a 32-bit machine. Unfortunately I'm running on 64-bit.
comment:22 in reply to: ↑ 20 Changed 9 years ago by
Replying to davidloeffler:
- Install #9898/#9753/#9764 and test everything in sage/rings.
- Then install #7883 and the combined patch from this ticket, and do sage/rings again.
- Then install #9359 and repeat.
I'm a little nervous about silly doctest failures coming up from Pari's unpredictable choices of generators of ideals, and this would set my mind at rest a bit :-)
I will do this (and should have done it for my patches).
comment:23 Changed 9 years ago by
- Description modified (diff)
comment:24 Changed 9 years ago by
I have testing the following chain of patches on a 32-bit PPC machine:
trac_7883-ideals-folded.patch 9898_pari_decl.patch 9753.patch 9764_ideal_repr_new.patch 8333_8334_ALL-rebased_for_9764.patch
The only failure was in sage/schemes/generic/toric_divisor.py
, which is a known problem.
comment:25 Changed 9 years ago by
- Status changed from positive_review to needs_work
Could someone please update the commit string of 8333_8334_ALL-rebased_for_9764.patch so its first line is a < 80 (or so) character summary that includes the ticket number, then restore the positive review? Additional lines are no problem, of course.
comment:27 Changed 9 years ago by
- Merged in set to sage-4.6.alpha2
- Resolution set to fixed
- Status changed from positive_review to closed
comment:28 Changed 9 years ago by
This seems to have sorted #9409, which needs a reviewer to verify my check.
comment:29 Changed 8 years ago by
David, I'm not very satisfied with the change in french_book/numbertheory.py
done by this patch, for two reasons:
(1) the previous error message was better. (In the book we wanted to show that the isomorphism
between two instances of GF(3^{2}) is not automatic in Sage.)
(2) this is more serious. We have put this doctest in Sage so that the examples of our book (which
is now published) still work with future versions of Sage. By changing the error message you did break the examples on http://sagebook.gforge.inria.fr/. Moreover you did not even contact us to discuss this change.
For (1) is it possible to revert to the previous error message?
For (2) in case you want to change some file in the tests directory, please first inform the corresponding author.
Paul Zimmermann
comment:30 Changed 8 years ago by
Paul: I'm sorry, I didn't mean to break anything -- I didn't know there was an official policy of not making changes to the tests directory. Can you point me to where this policy is explicitly written down?
comment:31 Changed 8 years ago by
- Cc was added
David (Loeffler), I didn't write to you, but to David Roe... You are just the reviewer. This policy is explained in http://groups.google.com/group/sage-support/msg/3ea7ed2eeab0824a :
Note that you could also submit a patch to Sage with the code you're doctesting. I did that with all the tests from both of the books I published, and I encourage you and many others to do the same with the code from your article. The code would go in a file devel/sage/sage/tests/ like the file devel/sage/sage/tests/book_stein_modform.py In fact, I could imagine having dozens of files in that directory, and when doctests break there, we could notify the authors before releasing the version of Sage that breaks their doctests for feedback -- then they could update their papers or Sage.
My personal opinion is that "we could notify" should read "we should notify"...
Paul
comment:32 Changed 8 years ago by
Sorry for the change to the tests folder. When I split up a patchbomb into #8334 and #8335 (among others), I changed some errors to NotImplementedError
for coercions that would soon work in #8335. Unfortunately that ticket has stagnated.
While I'm working on fixing #8335, I've made a new ticket (#12084) that restores the original TypeError
. It's ready for review. Sorry for the trouble, and I'll be more careful with the sage/tests
directory in the future.
comment:33 Changed 5 years ago by
What's with all the commented-out doctests added here? See #16946.
Apply after other patch