Opened 12 years ago

Closed 12 years ago

#8294 closed defect (fixed)

Copy is broken on 2x2 integer matrix (mutability is not set)

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.3.4
Component: linear algebra Keywords: Matrix 2x2, mutability, copy
Cc: Merged in: sage-4.3.4.alpha0
Authors: Florent Hivert Reviewers: Martin Raum
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage: M = sage.matrix.matrix_integer_2x2.MatrixSpace_ZZ_2x2()
sage: mat = M([3,4,5,6])
sage: mat.is_mutable()
True
sage: mat = copy(mat)
sage: mat.is_mutable()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/hivert/<ipython console> in <module>()

/usr/local/sage2/local/lib/python2.6/site-packages/sage/matrix/matrix0.so in sage.matrix.matrix0.Matrix.is_mutable (sage/matrix/matrix0.c:3928)()

AttributeError: 'NoneType' object has no attribute 'is_mutable'

Attachments (1)

trac_8294-matrix_2x2_copy_mutability_fix-fh.patch (1.3 KB) - added by hivert 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by hivert

  • Owner changed from h to hivert

Should be ready for review.

Florent

comment:2 Changed 12 years ago by hivert

  • Status changed from new to needs_review

comment:3 follow-up: Changed 12 years ago by mraum

  • Reviewers set to Martin Raum
  • Status changed from needs_review to positive_review

This applies cleanly and all tests pass. Positive review as is. #8276 will follow soon.

comment:4 in reply to: ↑ 3 Changed 12 years ago by hivert

Replying to mraum:

This applies cleanly and all tests pass. Positive review as is. #8276 will follow soon.

Thanks a lot for this quick help !

comment:5 Changed 12 years ago by mvngu

  • Merged in set to sage-4.3.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.