developer's guide: document the variable SAGE_CHECK

[Minh Van Nguyen]

As the subject says.

[David Kirkby]

See also #8263, which aims to document all environment variables. SAGE_CHECK is not the only one which is either undocumented, or poorly documented.

[Mitesh Patel]

Some somewhat related data: SAGE_LOCAL/bin/sage-spkg contains

    cd $BASEDIR
    if [ "$SAGE_CHECK" != "" -a -f spkg-check ]; then
        echo "Running the test suite."
        chmod +x spkg-check
        ./spkg-check
        if [ $? -ne 0 ]; then

but

$ \ls -1 /home/release/latest/sage-4.3.3/spkg/standard/*.spkg | awk '{print "tar jxvf "$0}' > zz
$ . zz
$ gr -A3 -B2 spkg-check */spkg-install
flint-1.5.0.p3/spkg-install-
flint-1.5.0.p3/spkg-install-if [ "$SAGE_CHECK" = "yes" ]; then
flint-1.5.0.p3/spkg-install:    cd ..; ./spkg-check
flint-1.5.0.p3/spkg-install-fi
--
mpfr-2.4.1.p1/spkg-install-# Do not bypass the checks, as some MPFR failures
mpfr-2.4.1.p1/spkg-install-# have been observed, so MPFR should be carefully tested.
mpfr-2.4.1.p1/spkg-install:cd ..; ./spkg-check
--
mpir-1.2.2.p0/spkg-install-
mpir-1.2.2.p0/spkg-install-if [ "$SAGE_CHECK" = "yes" ]; then
mpir-1.2.2.p0/spkg-install:    cd ..; ./spkg-check
mpir-1.2.2.p0/spkg-install-fi

In particular, with SAGE_CHECK="yes", the flint's long-running tests are run twice.

[Robert Miller]

Can this ticket be closed now?

[Minh Van Nguyen]

Replying to rlm:

Can this ticket be closed now?

Yes, this ticket can be closed. The issue of this ticket has been fixed in #8263. I leave it to the release manager to close the current ticket.

[Robert Miller]

Right. Just wanted a second opinion. Thanks!

[Mitesh Patel]

Revisiting the comment above for Sage 4.5, I get

$ \ls -1 /path/to/sage-4.5/spkg/standard/*.spkg | awk '{print "tar jxvf "$0}' > unpackem
$ . unpackem
$ egrep -A3 -B2 -i SAGE_CHECK\|spkg-check */spkg-install
cliquer-1.2.p5/spkg-install-fi
cliquer-1.2.p5/spkg-install-
cliquer-1.2.p5/spkg-install:if [ "$SAGE_CHECK" = "yes" ]; then
cliquer-1.2.p5/spkg-install-    echo "Compiling and running the test cases of cliquer..."
cliquer-1.2.p5/spkg-install-
cliquer-1.2.p5/spkg-install-    make testcases
--
mpfr-2.4.2/spkg-install-# Do not bypass the checks, as some MPFR failures
mpfr-2.4.2/spkg-install-# have been observed, so MPFR should be carefully tested.
mpfr-2.4.2/spkg-install:cd ..; ./spkg-check
--
mpir-1.2.2.p1/spkg-install-fi
mpir-1.2.2.p1/spkg-install-
mpir-1.2.2.p1/spkg-install:if [ "$SAGE_CHECK" = "yes" ]; then
mpir-1.2.2.p1/spkg-install:    cd ..; ./spkg-check
mpir-1.2.2.p1/spkg-install-fi

If no one objects, I can open tickets for MPIR and Cliquer.

[Mitesh Patel]

Replying to mpatel:

If no one objects, I can open tickets for MPIR and Cliquer.

These are now #9522 (MPIR) and #9521 (Cliquer).