Opened 12 years ago

Closed 12 years ago

#8235 closed defect (fixed)

fix another doctest in base.pyx

Reported by: wcauchois Owned by: AlexGhitza
Priority: minor Milestone: sage-4.3.3
Component: graphics Keywords:
Cc: Merged in: sage-4.3.3.alpha0
Authors: Bill Cauchois Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mpatel)

This ticket is related to #7985. There's another doctest in base.pyx (on line 1308) that uses the output of texture_set(), which is inconsistent across machines since the order of Texture objects in a set is not well defined. This should be a trivial fix.

Related: #2872

Attachments (1)

trac_8235.patch (1.0 KB) - added by wcauchois 12 years ago.
based on sage 4.3.1

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by wcauchois

based on sage 4.3.1

comment:1 Changed 12 years ago by wcauchois

  • Status changed from new to needs_review

Its not terribly pretty, but this should fix it.

comment:2 Changed 12 years ago by mpatel

  • Authors set to Bill Cauchois
  • Component changed from algebra to graphics
  • Milestone set to sage-4.3.3
  • Priority changed from major to minor
  • Reviewers set to Mitesh Patel
  • Status changed from needs_review to positive_review

comment:3 Changed 12 years ago by mpatel

Running sage -t plot/plot3d/base.pyx 10 or so times in succession yields no failures. Positive review.

Please remember to set / update the relevant ticket fields.

Thanks!

comment:4 Changed 12 years ago by mpatel

  • Description modified (diff)

comment:5 Changed 12 years ago by mpatel

  • Description modified (diff)

comment:6 Changed 12 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.