Opened 9 years ago

Closed 9 years ago

#8225 closed defect (fixed)

%time now hugely broken in sagenb-0.7.4 (sage-4.3.2)

Reported by: was Owned by:
Priority: blocker Milestone: sage-4.3.4
Component: notebook Keywords:
Cc: Merged in: sagenb-0.7.5.3
Authors: Mitesh Patel Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mvngu)


On Tue, Feb 9, 2010 at 1:22 PM, finotti <luis.finotti@gmail.com> wrote:
> Dear all,
>
> Cells starting with "%time" stopped working with 4.3.2.  (It works
> with 4.3.1.)  Is it no long supported or is it a bug? (time still
> works with the command line.)
>
> Running on Linux 32-bit, ubuntu binary.
>
> Thanks,

Wow, what a horrible, horrible regression! Indeed, I've confirmed that what happens is that doing %time causes the notebook to hang forever, and be pretty broken thereafter. Ouch. The issue was reported at these sage-support and sage-notebook threads.

Attachments (1)

trac_8225-timeit_notebook.patch (833 bytes) - added by mpatel 9 years ago.
Fix %time and %timeit. sagenb repo.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by mvngu

  • Description modified (diff)

Changed 9 years ago by mpatel

Fix %time and %timeit. sagenb repo.

comment:2 Changed 9 years ago by mpatel

  • Status changed from new to needs_review

comment:3 Changed 9 years ago by ddrake

I can confirm that this patch fixes the problem with %time on 4.3.3, and %timeit also works, but doesn't work as it does on the command line -- there, %timeit runs multiple loops and so on. Is that how %timeit has always worked in the notebook?

I don't know this particular code very well, but the patch appears to fix the problem and seems okay. So consider this a quite weak positive review.

comment:4 Changed 9 years ago by mpatel

I think %timeit has worked that way in the notebook. See this sage-devel thread. The worksheet I mentioned is now here.

comment:5 Changed 9 years ago by was

  • Status changed from needs_review to positive_review

comment:6 Changed 9 years ago by mhansen

  • Authors set to Mitesh Patel
  • Owner changed from was to (none)
  • Reviewers set to William Stein

comment:7 Changed 9 years ago by mpatel

  • Merged in set to sagenb-0.7.5.3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.