Opened 7 years ago

Closed 7 years ago

Last modified 14 months ago

#8215 closed defect (fixed)

The empty word is a factor of a word

Reported by: slabbe Owned by: slabbe
Priority: major Milestone: sage-4.3.3
Component: combinatorics Keywords: empty word
Cc: sage-combinat, abmasse Merged in: sage-4.3.3.alpha0
Authors: Sébastien Labbé Reviewers: Alexandre Blondin Massé
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by slabbe)

The following results should be True. 

sage: Word().is_factor(Word())
False
sage: Word().is_factor(Word('abad'))
False
sage: Word().is_factor(Word([0,1,2]))
False
sage: Word('').is_factor(Word('abad'))
False
sage: Word([]).is_factor(Word([0,1,2]))
False

Attachments (1)

trac_8215_empty_word-sl.patch​ (1.5 KB) - added by slabbe 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by slabbe

comment:1 Changed 7 years ago by slabbe

  • Authors set to Sebastien Labbe
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by abmasse

  • Reviewers set to Alexandre Blondin Massé
  • Status changed from needs_review to positive_review

Tested on sage 4.3.1. Doc builds fine, all tests passed and it fixes the bug. Not much more to say... Positive review !

comment:3 Changed 7 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Owner changed from slabbe to mpatel

comment:4 Changed 7 years ago by mpatel

  • Owner changed from mpatel to slabbe

Oops!

comment:5 Changed 7 years ago by mpatel

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 14 months ago by chapoton

  • Authors changed from Sebastien Labbe to Sébastien Labbé
Note: See TracTickets for help on using tickets.