Opened 10 years ago
Closed 5 years ago
#8205 closed defect (fixed)
Document ProxyPreserveHost (was: fix the base URL for published worksheet)
Reported by: | was | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | notebook | Keywords: | |
Cc: | acleone, timdumol | Merged in: | |
Authors: | Reviewers: | Karl-Dieter Crisman | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I upgraded sagenb.org to sagenb-0.7.4, and excitedly hoped that when I click publish to publish a worksheet it would give me the correct URL. Now it says:
"Worksheet is publicly viewable at http://localhost:8888/home/pub/1153"
This is wrong. This might even be considered worse than before, since before it did "... http://:8888/home/pub/1153" which was obviously wrong. The above looks less obviously wrong.
Change History (11)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
- Cc acleone timdumol added
comment:3 Changed 10 years ago by
Adding ProxyPreserveHost On to the notebook server VirtualHost
s in /etc/apache2/httpd.conf
on boxen
seems to work. If it works well, we should mention it in the notebook?
docstring.
comment:4 Changed 10 years ago by
- Summary changed from sagenb -- the url for published worksheets that's displayed right after publishing is still wrong to Document ProxyPreserveHost (was: fix the base URL for published worksheet)
comment:5 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:6 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:7 Changed 5 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:8 Changed 5 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:9 Changed 5 years ago by
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
- Reviewers set to Karl-Dieter Crisman
- Status changed from new to needs_review
This now works properly on sagenb.org, anyway
Worksheet is publicly viewable at http://sagenb.org/home/pub/5051
I tested it on another server as well, not sure where this was fixed.
comment:10 Changed 5 years ago by
- Status changed from needs_review to positive_review
comment:11 Changed 5 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
I think the most robust fix may be to just add another option to the notebook command that specifies the correct URL base instead of trying to cleverly figure it out.