Opened 13 years ago

Closed 13 years ago

#8184 closed defect (fixed)

eclib upgrade and bugfix

Reported by: cremona Owned by: cremona
Priority: major Milestone: sage-4.3.3
Component: elliptic curves Keywords: eclib
Cc: Merged in: sage-4.3.3.alpha0
Authors: John Cremona Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

We provide an upgrade to eclib to patch-level 9, i.e. eclib-20080310.p9.spkg. This does two things:

  1. Fixes a bug (found by Edray Goins and Jamie Wiegandt) in which second descent quartics were not tested for real-solubility, and so sometimes the rank bounds (and related selmer ranks) could be too high.
  1. Enhances the data available from the two_descent class so that the rank_bound and selmer_rank are separated, and both available.

The second item necessitated changes to the interface, which are here included in the patch. In turn, some changes were needed in sage/schemes/elliptic_curve/

Note that this affects #7575.

Attachments (3)

eclib-20080310.p9.spkg (1.5 MB) - added by cremona 13 years ago.
trac_8184-eclib.patch (17.4 KB) - added by cremona 13 years ago.
Applies to 4.3.2.alpha1
trac_8184-indentation.patch (6.8 KB) - added by rlm 13 years ago.
Apply on top of trac_8184-eclib.patch

Download all attachments as: .zip

Change History (11)

Changed 13 years ago by cremona

comment:1 Changed 13 years ago by cremona

  • Status changed from new to needs_review

comment:2 Changed 13 years ago by wuthrich

I fear you uploaded the wrong patch.

I am not certain how to review packages and I will read up on it; but someone might be faster at it.

Chris.

Changed 13 years ago by cremona

Applies to 4.3.2.alpha1

comment:3 Changed 13 years ago by cremona

Sorry -- try this one.

NB After building the new spkg with "sage -f" the patch is required before Sage will work properly. Even in a clone, you'll be stuck with the new spkg. I am not sure how to revert back to the old eclib (if you want to).

So I would recommend tetsing this on (say) 4.3.2.alpha1 if you have it, and if all goes wrong you can build 4.3.2.rc0 which is out!

Changed 13 years ago by rlm

Apply on top of trac_8184-eclib.patch

comment:4 Changed 13 years ago by rlm

I added a patch which replaces tabs with single spaces (it looks like your editor sees tabs as eight spaces... mine only sees them as four).

comment:5 Changed 13 years ago by rlm

  • Reviewers set to Robert Miller
  • Status changed from needs_review to positive_review

I've tested this on 32-bit OS X and 64-bit Linux, and there are no problems. Looks great!

comment:6 Changed 13 years ago by wuthrich

I knew someone would be faster. Thanks.

comment:7 Changed 13 years ago by mpatel

The indentation patch seems to be missing the committer's name and email address, and the commit string does not contain the ticket number. I've refreshed the patch and applied it to 4.3.3.alpha0.

comment:8 Changed 13 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.