#8165 closed defect (fixed)
Title cut off on worksheet download
Reported by: | jason | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.3 |
Component: | notebook | Keywords: | |
Cc: | Merged in: | sagenb-0.7.5 | |
Authors: | Mitesh Patel | Reviewers: | Rob Beezer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I just tried uploading the following worksheet:
http://sagenb.org/home/pub/1139/
by pasting the URL into the middle box of the upload page on a (fairly fresh) 4.3.1 install. When I opened up the worksheet on the local server, the title was cut off to be about 14 characters long. This is a bug.
Attachments (1)
Change History (7)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
The problem is the use of str.rstrip in twist.Worksheet_download
:
sage: '112 - 01 - Review.sws'.rstrip('.sws') '112 - 01 - Revie'
The patch uses str.endswith
and a slice, instead.
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
- Summary changed from title cuts off on worksheet upload to Title cut off on worksheet download
comment:4 Changed 11 years ago by
- Reviewers set to Rob Beezer
- Status changed from needs_review to positive_review
I've reproduced the problem on 4.3.1, then applied the patch on top of sagenb-0.7.4.spkg and the title survives properly when saved to an sws file and subsequently loaded into a notebook.
Positive review.
comment:5 Changed 11 years ago by
- Merged in set to Mitesh Patel
- Resolution set to fixed
- Status changed from positive_review to closed
comment:6 Changed 11 years ago by
- Merged in changed from Mitesh Patel to sagenb-0.7.5
Note: See
TracTickets for help on using
tickets.
Don't use
rstrip
to chop'.sws'
. sagenb repo.