Opened 12 years ago

Closed 12 years ago

#8155 closed defect (fixed)

add sig_on/sig_off to sage.schemes.elliptic_curves.descent_two_isogeny

Reported by: rlm Owned by: cremona
Priority: major Milestone: sage-4.3.3
Component: elliptic curves Keywords:
Cc: Merged in: sage-4.3.3.alpha0
Authors: Robert Miller Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rlm)

Otherwise a KeyboardInterrupt will be ignored during the call to ratpoints.

Attachments (1)

trac_8155.patch (5.8 KB) - added by rlm 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by rlm

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by rlm

  • Description modified (diff)

Changed 12 years ago by rlm

comment:3 Changed 12 years ago by cremona

  • Status changed from needs_review to positive_review

I applied the patch successfully to 4.3.2 with the spkg and patches at #8184 already applied, with no problem.

Testing the whole library (without -long): all test pass. Positive review!

comment:4 Changed 12 years ago by rlm

  • Reviewers set to John Cremona

comment:5 Changed 12 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.