Opened 12 years ago

Closed 12 years ago

#8107 closed enhancement (fixed)

Fewer unnecessary imports from `sage.server.*`

Reported by: mpatel Owned by: was
Priority: minor Milestone: sage-4.3.2
Component: notebook Keywords:
Cc: robertwb, timdumol Merged in: sage-4.3.2.alpha1
Authors: Mitesh Patel Reviewers: Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This should reduce startup time, according to sage -startuptime.

Attachments (1)

trac_8107-server_imports.patch​ (2.7 KB) - added by mpatel 12 years ago.
sage repo.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by mpatel

sage repo.

comment:1 Changed 12 years ago by mpatel

  • Cc timdumol added
  • Status changed from new to needs_review

The sage-repository patch and #8102 together reduce the overall time for me from ~1.9 s to ~1.7 s.

comment:2 Changed 12 years ago by mpatel

I'm sure we can do better with #7502...

comment:3 Changed 12 years ago by was

  • Status changed from needs_review to positive_review

Awesome -- I was just being annoyed by precisely these imports last night.

comment:4 follow-up: Changed 12 years ago by robertwb

A big +1 from me too. I'm curious about the comment 

# We import the following two only for doctesting purposes

though.

comment:5 in reply to: ↑ 4 Changed 12 years ago by mpatel

Replying to robertwb:

A big +1 from me too. I'm curious about the comment 

# We import the following two only for doctesting purposes

I'm not sure, but post-#7650, these imports should be unnecessary. The patch above does not affect the results of make ptestlong on sage.math.

comment:6 Changed 12 years ago by mvngu

  • Merged in set to sage-4.3.2.alpha1
  • Resolution set to fixed
  • Reviewers set to Robert Bradshaw
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.