Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8093 closed enhancement (fixed)

Adding of prefixes and palindrome prefixes iterators to the Words library

Reported by: abmasse Owned by: abmasse
Priority: major Milestone: sage-4.3.3
Component: combinatorics Keywords: palindrome, prefix
Cc: slabbe Merged in: sage-4.3.3.alpha0
Authors: Alexandre Blondin Massé Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Adds three functions to iterate over prefixes and palindrome prefixes of finite and infinite words.

Attachments (2)

trac_8093_palindromes_prefixes-abm.patch​ (3.9 KB) - added by abmasse 7 years ago.
Updated to synchronize with sage-combinat mercurial repository -- should be the same file
trac_8093_doc_fixes-sl.patch​ (1.4 KB) - added by slabbe 7 years ago.
Applies over the precedent patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by abmasse

  • Status changed from new to needs_review

Changed 7 years ago by abmasse

Updated to synchronize with sage-combinat mercurial repository -- should be the same file

Changed 7 years ago by slabbe

Applies over the precedent patch

comment:2 Changed 7 years ago by slabbe

  • Authors set to Alexandre Blondin-Massé
  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

All tests passed in sage/combinat/words. Doc builds fine. Code is good.

I added a small patch that edits the INPUT block and adds a TEST.

Positive review.

comment:3 Changed 7 years ago by abmasse

Alright with the modifs as far as I'm concerned.

comment:4 Changed 7 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 7 years ago by mpatel

  • Authors changed from Alexandre Blondin-Massé to Alexandre Blondin Massé

I'm updating the Author field per ​the main wiki page. Please let us know if they're wrong.

comment:6 Changed 7 years ago by abmasse

Thanks, this is indeed the right name (without dash).

Note: See TracTickets for help on using tickets.