Opened 10 years ago
Closed 10 years ago
#8081 closed defect (fixed)
documentation bug on new gale_ryser_theorem()
Reported by: | mvngu | Owned by: | mvngu |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.3.2 |
Component: | documentation | Keywords: | |
Cc: | ncohen, wdj | Merged in: | sage-4.3.2.alpha1 |
Authors: | Nathann Cohen | Reviewers: | David Joyner |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
In the module sage/combinat/integer_vector.py
, the documentation for the function gale_ryser_theorem()
should be fixed as per the following suggestion:
On the recently added gale_ryser_theorem() there's a documentation bug (also present on the changelog) "The Gale Ryser theorem asserts that if p1;p2 are two partitions of n of respective lengths k1;k2 , then there is a binary k1Âk2 matrix M such that p1 is the vector of row sums and p2 is the vector of column sums of M , if and only if p2 dominates p1 ." At the end it should say "p2 conjugate (transpose) dominates p1" The theorem is mis-stated yet the function seems to be working
See this sage-devel thread for the original bug report.
Attachments (1)
Change History (5)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Reviewers set to David Joyner
- Status changed from needs_review to positive_review
Applies fine to 4.3.2.a0 and passes all but the 2 tests that failed previously on a mac 10.6.2.
Good docstring patch. Thanks Nathann!
Positive review.
comment:3 Changed 10 years ago by
Nathann, the ticket number is very useful for tracking down changes. You might consider putting it in your commit message. See this section of the Developers' Guide.
comment:4 Changed 10 years ago by
- Merged in set to sage-4.3.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Here it is !!!