Opened 11 years ago

Closed 11 years ago

#8070 closed enhancement (fixed)

New pycrypto-2.0.1.p5.spkg builds 64-bit with Open Solaris x64.

Reported by: jsp Owned by: drkirkby
Priority: major Milestone: sage-4.3.3
Component: porting Keywords:
Cc: Merged in: sage-4.3.3.alpha0
Authors: Jaap Spies Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Let SAGE64="yes" work with Open Solaris 64 bit too.

The spkg is here: http://boxen.math.washington.edu/home/jsp/ports/pycrypto-2.0.1.p5.spkg

byte-compiling /export/home/jaap/Downloads/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.py to __init__.pyc
running install_egg_info
Writing /export/home/jaap/Downloads/sage-4.3.1/local/lib/python2.6/site-packages/pycrypto-2.0.1-py2.6.egg-info

real	0m5.851s
user	0m4.285s
sys	0m0.920s
Successfully installed pycrypto-2.0.1.p5
You can safely delete the temporary build directory
/export/home/jaap/Downloads/sage-4.3.1/spkg/build/pycrypto-2.0.1.p5
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing pycrypto-2.0.1.p5.spkg
jaap@opensolaris:~/Downloads/sage-4.3.1$ 

Jaap

Attachments (2)

pycrypto-2.0.1.p5.patch (1019 bytes) - added by jsp 11 years ago.
pycrypto-2.0.1.p5+.patch (408 bytes) - added by jsp 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by jsp

  • Status changed from new to needs_review

Changed 11 years ago by jsp

comment:2 Changed 11 years ago by drkirkby

  • Reviewers set to David Kirkby
  • Status changed from needs_review to needs_work

It has 'echo "64 bit MacIntel?" which is not correct.

Changed 11 years ago by jsp

comment:3 Changed 11 years ago by jsp

  • Cc drkirby was removed
  • Status changed from needs_work to needs_review

Done.

Jaap

comment:4 Changed 11 years ago by drkirkby

  • Status changed from needs_review to positive_review
  • Summary changed from New pycrypto-2.0.1.p5.spkg works with Open Solaris 64 bit to New pycrypto-2.0.1.p5.spkg builds 64-bit with Open Solaris x64.

That's fine. In future, it would be helpful if you could show evidence that the package is building ok, as

Successfully installed pycrypto-2.0.1.p5

does not prove very much. Plenty of packages claim to 'sucessfully' install in Open Solaris, yet in practice they do not. In this case, we can see:

copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/AES.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES3.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher

and using 'file' in the directory, I can indeed see the binaries are now 64-bit.

drkirkby@hawk:~/sage-4.3.1$ file /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/*
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/AES.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/ARC2.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/ARC4.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/Blowfish.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/CAST.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/DES3.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/DES.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/IDEA.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.py:	English text
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.pyc:	data
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/RC5.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/XOR.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
drkirkby@hawk:~/sage-4.3.1$ 

So a positive review from me.

Sorry to sometimes ask for extra things, but it is easier for the reviewer if he can see evidence this fixes the bug. As I've done many of these Solaris fixes, and see some from you, I can see ways of improving some things.

Dave

comment:5 Changed 11 years ago by mpatel

  • Merged in set to sage-4.3.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.