#8053 closed enhancement (duplicate)
graph editor minor bugs and improvements
Reported by: | rkirov | Owned by: | was |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | notebook | Keywords: | |
Cc: | mpatel | Merged in: | |
Authors: | rkirov | Reviewers: | Mitesh Patel |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
There was bug in the graph_editor which counted the release of a dragging move as a beginning of a double click. This should reduce the number of accidental node deletions.
Also added the following improvements.
- there is one-step undo available.
- a node dragged out of the iframe returns to its original position. Deletion is preformed only if mouse is released between the canvas and the iframe.
- live sliders only shown when live is enabled.
- live algorithm never pushes nodes out of bounds.
Note that JSbeautifier.com moved some if else statements indents which is reflected in the patch (even though there was not actual code change in those parts).
Attachments (1)
Change History (6)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Reviewers set to Mitesh Patel
comment:3 Changed 11 years ago by
- Status changed from needs_review to needs_work
thanks, mitesh I will make a few more edits and submit a new patch.
comment:4 Changed 11 years ago by
- Resolution set to duplicate
- Status changed from needs_work to closed
merged with ticket 8222
comment:5 Changed 11 years ago by
- Milestone changed from sage-4.4 to sage-duplicate/invalid/wontfix
Note: See
TracTickets for help on using
tickets.
The patch looks good. The new features and fixes are great!
graph_editor.js
through JSLint on its "The Good Parts" setting. (Feel free to setwhite: true
at the top of the file, since the beautifier now takes care of that.). It found:;
at the end of line 6.removed_node
is not defined. I suggest adding it to line 6.