Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8051 closed defect (fixed)

SageNB 0.7.x

Reported by: mpatel Owned by:
Priority: major Milestone: sage-4.3.2
Component: notebook Keywords:
Cc: Merged in: sage-4.3.2
Authors: Mitesh Patel Reviewers: Robert Mařík, Minh Van Nguyen, Alex Leone
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mpatel)

The new spkg is at

Merged in 0.7: #7249, #7962, #7969, #4217, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

Merged in 0.7.1: #8103.

Merged in 0.7.2: #3083's "notruncate" patch.

Merged in 0.7.3: #7784.

Merged in 0.7.4: #8167, #8102, #8160.

Change History (42)

comment:1 Changed 9 years ago by mpatel

  • Authors set to Mitesh Patel
  • Description modified (diff)

comment:2 follow-up: Changed 9 years ago by mpatel

  • Cc acleone timdumol was added
  • Status changed from new to needs_review

If it's possible, I'd like to get into 0.7.1 as many of the now remaining "needs review" tickets as we can. I'm rebasing these now.

comment:3 in reply to: ↑ 2 Changed 9 years ago by mpatel

Replying to mpatel:

If it's possible, I'd like to get into 0.7.1 as many of the now remaining "needs review" tickets as we can. I'm rebasing these now.

Here's a possible queue:

trac_7784-hgignore_update.patch
trac_5712-interrupt-notification.5.patch
trac_6069-missing_pub_ws.2.patch
trac_8038-email_plus_addressing_v2.patch
trac_7506-notebook_object-documentation.2.patch
trac_693-spawn_notebook.3.patch
trac_5177-delete-cell-dirs.3.patch

comment:4 Changed 9 years ago by mpatel

  • blockedby set to 7249
  • Owner changed from was to mpatel

comment:5 Changed 9 years ago by mpatel

  • blockedby 7249 deleted

comment:6 Changed 9 years ago by mpatel

  • Description modified (diff)
  • Summary changed from SageNB 0.7 to SageNB 0.7.1

comment:7 Changed 9 years ago by mpatel

  • Description modified (diff)

I just noticed that long 'eval' docstrings are truncated. I'll add a reviewer patch to #3083.

comment:8 Changed 9 years ago by mpatel

  • Description modified (diff)
  • Summary changed from SageNB 0.7.1 to SageNB 0.7.2

comment:9 follow-up: Changed 9 years ago by robert.marik

All tickets got positive review and have been merged. So what should be reviewed in this ticket?

I installed the spkg, seems to work fine (but I did not test everything), is this enough to give positive review?

btw: the link from description "says" http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg but it points to http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg

comment:10 in reply to: ↑ 9 Changed 9 years ago by mvngu

Replying to robert.marik:

All tickets got positive review and have been merged. So what should be reviewed in this ticket?

You need to make sure that you can successfully install the updated spkg.

I installed the spkg, seems to work fine (but I did not test everything), is this enough to give positive review?

I would say, all doctests must pass as well. In any case, if you can't run all doctests after installing the updated spkg, I can do that. A correct link to the updated spkg is

http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg

comment:11 Changed 9 years ago by mvngu

I don't understand why the spkg is not managed by Mercurial:

[mvngu@mod sagenb-0.7.2]$ hg st
abort: There is no Mercurial repository here (.hg not found)!

The file spkg-install should have its executable bits on:

[mvngu@mod sagenb-0.7.2]$ ls -g spkg-install
-rw-r--r-- 1 mvngu 348 2010-01-30 16:37 spkg-install

And SPKG.txt is very sketchy about update details.

comment:12 Changed 9 years ago by mpatel

I suggest

  • Checking that the package installs and the notebook runs.
  • Checking the repo for unchecked-in changes, queued patches, etc.
  • Checking that the claimed merged tickets appear in hg log.
  • Running the doctests: sage -t -sagenb.

Ideally, you should run the SageNB Selenium tests, too. But they require special extra setup. I'll make simplifying that setup a separate ticket.

Thanks for pointing out the link error. I've updated it.

comment:13 follow-up: Changed 9 years ago by mpatel

The repository is in sagenb-0.7.2/src/sagenb. We auto-generate the package with sagenb-0.7.2/src/sagenb/spkg-dist.

I suggest that I make a separate ticket to update SPKG.txt.

See #7784 about

$ hg stat
? release_notes.txt
? setup.cfg

comment:14 in reply to: ↑ 13 Changed 9 years ago by mpatel

Replying to mpatel:

I suggest that I make a separate ticket to update SPKG.txt.

Or I can do this here later today.

comment:15 Changed 9 years ago by mpatel

I'll fix the spkg-install problem, too.

comment:16 Changed 9 years ago by mpatel

  • Reviewers set to Robert Mařík, Minh Van Nguyen

Please see #7784 for the changes. If/when that ticket gets a positive review, I'll create SageNB 0.7.3 and post it here.

comment:17 Changed 9 years ago by mpatel

By the way, it seems that for the near future, I may be the only very active SageNB developer. I'd be very happy to be proved (proven?) wrong! There are many tasks to complete --- there are several cool new notebook features to implement. It's not possible for me to cover them all, and I'd like to avoid stalling ongoing development.

To this end, I'll try to make it easier for Sage developers to review notebook tickets or make other contributions. Please let me know what would help. For example, I can make experimental spkgs that contain the latest patches in the queue. Those who wish just to test the cumulative changes can install the package with sage -f sagenb-*.spkg. But reviewers can also open the spkg, pop / push patches, and comment on specific ticket(s). In either case, we'll get useful information about how the notebook behaves in a wider gamut of browser-OS combinations. We'll also get more end user feedback.

comment:18 follow-up: Changed 9 years ago by acleone

Experimental spkgs would be good. I think the best way to get more testing/review would be a good guide to applying patches, testing spkgs, etc.

Is there a mailing list or wiki page for coordinating development effort?

comment:19 in reply to: ↑ 18 Changed 9 years ago by mvngu

Replying to acleone:

Is there a mailing list or wiki page for coordinating development effort?

A relevant mailing is sage-devel. Most of the time, that list receives high volume traffic on development discussion. For coordinating release effort, the sage-release mailing list is appropriate. Some effort is underway to expand the Sage documentation with information to help beginners getting started with Sage development. The relevant tickets are:

  1. #8108: Expand the Sage Developer Guide for newcomers
  2. #6987: reorganize section on producing patches with Mercurial
  3. #8079: Better documentation for patching spgk's
  4. #8104: developer's guide for making spkgs should specify that patches need to be version controlled
  5. #3882: explain in the programming guide why spkg source patches should be applied by copying entire files
  6. #7944: update Developers' Guide to reflect new process for working on tickets

comment:20 Changed 9 years ago by mpatel

Both sage-devel and sage-notebook are good places. I suppose we should move this discussion to sage-notebook.

One source for ideas is SageTasks, but it may be getting old.

Addendum: Of course, we should also try to attract energetic developers who'd contribute fresh ideas, techniques, etc., to the SageNB project.

comment:21 Changed 9 years ago by mpatel

While I'm here, I'd also like to suggest using alpha.sagenb.org or creating ouch.sagenb.org to test a bleeding-edge SageNB. This could be a notebook with all positively reviewed patches applied or, more interestingly, an experimental spkg.

We could also set up a corresponding repository, different from http://boxen.math.washington.edu:8100/, to which to push experimental features and from which to backport what works. A potential problem here is that Mercurial changesets are immutable. But we might not care about keeping the history of this repository clean.

Just some thoughts.

comment:22 Changed 9 years ago by robert.marik

Installs fine, works fine with jsmath image fonts, tests paseed, cannot check the rest, since I have probably old hg in my Debian Linux

sage@um-bc107:~/sagenb-0.7.2/src/sagenb$ hg log
abort: requirement 'fncache' not supported!
sage@um-bc107:~/sagenb-0.7.2/src/sagenb$ hg status
abort: requirement 'fncache' not supported!

Can someone finish testing? I think that this is very important ticket and nice sage notebook is important to attract new users (and new developers). Thank you for working on it.

comment:23 Changed 9 years ago by mpatel

If you have a spare moment, please review #7784, which is "blocking" this ticket.

You can use sage -hg instead of hg.

comment:24 follow-up: Changed 9 years ago by mpatel

  • Description modified (diff)
  • Summary changed from SageNB 0.7.2 to SageNB 0.7.3

Minh -- Even with #8036, it's very likely the PDF reference manual won't build with this spkg, owing to #7249's Unicode doctests. I'm not sure what we should do about this.

comment:25 in reply to: ↑ 24 Changed 9 years ago by mvngu

Replying to mpatel:

Minh -- Even with #8036, it's very likely the PDF reference manual won't build with this spkg, owing to #7249's Unicode doctests. I'm not sure what we should do about this.

The release deadline for Sage 4.3.2 is Saturday 06th February 2010, which means there's not much time for sorting out failures when building the PDF version of the reference manual. I think sagenb-0.7.3.spkg needs to wait for after Sage 4.3.2 is done.

comment:26 Changed 9 years ago by mpatel

  • Cc acleone timdumol was removed

Please see #8167. If/when that ticket gets a positive review, I'll make 0.7.4...

comment:27 Changed 9 years ago by mpatel

  • Description modified (diff)
  • Summary changed from SageNB 0.7.3 to SageNB 0.7.x

I've posted SageNB 0.7.4 for review.

comment:28 Changed 9 years ago by robert.marik

Thanks for the update. But now I have too many sage notebooks

[marik@um-bc107 ../lib/python/site-packages]$ pwd
/opt/sage/local/lib/python/site-packages
[marik@um-bc107 ../lib/python/site-packages]$ ls -ld sagenb*
drwxr-xr-x 4 marik marik 4096  1. úno 17.16 sagenb-0.6-py2.6.egg
drwxr-xr-x 4 marik marik 4096  2. úno 19.33 sagenb-0.7.2-py2.6.egg
drwxr-xr-x 4 marik marik 4096  5. úno 09.13 sagenb-0.7.4-py2.6.egg

How do I know, which one is actually used? Jsmath image fonts failed to install intro correct directory. Should the old sage notebook be removed, first? Should this be tested on fresh install only?

comment:29 Changed 9 years ago by mpatel

We install the sagenb package with setuptools (PyPI), which updates SAGE_LOCAL/lib/python/site-packages/easy-install.pth. This file contains paths prepended to sys.path on startup.

You can query the installed version with

sage: from sagenb.misc.misc import SAGENB_VERSION
sage: SAGENB_VERSION

which is essentially

sage: from pkg_resources import Requirement, working_set
sage: w = working_set.find(Requirement.parse('sagenb'))
sage: w.version

Moreover, w.location gives the install directory.

I'm checking the fonts now...

comment:30 follow-up: Changed 9 years ago by acleone

  • Reviewers changed from Robert Mařík, Minh Van Nguyen to Robert Mařík, Minh Van Nguyen, Alex Leone

sagenb 0.7.4 installed correctly for me. All doc and selenium tests passed. Still problems building the PDF docs but Ihaven't applied any of the unicode patches (using vanilla sage-4.3.2.alpha1).

comment:31 Changed 9 years ago by mpatel

On the fonts: What is the output of

egrep "Copying jsMath image"\|"Installed.*sagenb" $SAGE_ROOT/install.log 

?

comment:32 in reply to: ↑ 30 Changed 9 years ago by mpatel

Replying to acleone:

sagenb 0.7.4 installed correctly for me. All doc and selenium tests passed. Still problems building the PDF docs but Ihaven't applied any of the unicode patches (using vanilla sage-4.3.2.alpha1).

Positive review?

comment:33 Changed 9 years ago by acleone

$ egrep "Copying jsMath image"\|"Installed.*sagenb" ~/sage-dev/sage-4.3.2.alpha1/install.log
Installed /home/alex/sage-dev/sage-4.3.2.alpha1/local/lib/python2.6/site-packages/sagenb-0.6-py2.6.egg

Strange.

sage: from sagenb.misc.misc import SAGENB_VERSION
sage: SAGENB_VERSION
'0.7.4'

Here's how I installed:

  1. make on an unmodified 4.3.2.alpha1
  2. $ tar -jxvf sagenb-0.7.4.spkg
    $ cd sagenb-0.7.4/src/sagenb/
    $ sage -python setup.py develop
    
  3. Tested with sage -t -sagenb
  4. Selenium tests with sage -python sagenb/testing/run_tests.py
  5. Checking the PDF build with sage -docbuild all pdf

comment:34 Changed 9 years ago by mpatel

I think this is OK, because the SAGE_LOCAL/bin/sage-spkg script invoked by sage -f updates SAGE_ROOT/install.log but the sage -python setup.py commands do not.

comment:35 Changed 9 years ago by acleone

The "Use image fonts" option is disabled (greyed out) in jsMath - is this a problem?

jsMath v3.6c (Unicode fonts)

comment:36 Changed 9 years ago by mpatel

Are the image fonts installed? In twist.py, we set the boolean

jsmath_image_fonts = is_package_installed("jsmath-image-fonts")

which propagates to jsmath.js. This should enable the option if the spkg is installed. But the fonts need to be installed in the right place...

comment:37 Changed 9 years ago by acleone

  • Status changed from needs_review to positive_review

Ok then, LGTM.

comment:38 Changed 9 years ago by was

  • Owner changed from mpatel to (none)

I decided to try something random to see if I was running the right notebook. So I tried #3154 first, and it appears that it is *NOT* fixed by this notebook upgrade. Other things I tried are fixed though.

comment:39 Changed 9 years ago by mpatel

  • Description modified (diff)

comment:40 Changed 9 years ago by mpatel

It turns out that I merged #4217, not #3154, into SageNB 0.7. I didn't notice that #4217's commit string was copied from #3154 by mistake. I used hg log to make the list of merged tickets in the description.

comment:41 Changed 9 years ago by mpatel

  • Merged in set to sage-4.3.2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:42 Changed 9 years ago by mvngu

  • Milestone changed from sage-4.3.3 to sage-4.3.2
Note: See TracTickets for help on using tickets.