Opened 13 years ago

Closed 13 years ago

#805 closed defect (fixed)

[with patch] is_trivial() does not work for fractional ideals of number field

Reported by: dmharvey Owned by: robertwb
Priority: major Milestone: sage-2.8.13
Component: number theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage: F.<a> = QuadraticField(-5)
sage: I = F.ideal(3)
sage: I.is_trivial()
---------------------------------------------------------------------------
<type 'exceptions.AttributeError'>        Traceback (most recent call last)

/Users/david/sage-2.8.5/<ipython console> in <module>()

/Users/david/sage-2.8.5/local/lib/python2.5/site-packages/sage/rings/ideal.py in is_trivial(self)
    229             return True
    230         elif self.is_principal():
--> 231             return self.gen().is_unit()
    232         raise NotImplementedError
    233 

<type 'exceptions.AttributeError'>: 'NumberFieldIdeal' object has no attribute 'gen'

Attachments (2)

805-trivial_nf_ideal.diff (1.5 KB) - added by robertwb 13 years ago.
805-ncalexan-general-2.diff (3.4 KB) - added by ncalexan 13 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by mabshoff

  • Milestone set to sage-2.9

comment:2 Changed 13 years ago by was

  • Milestone changed from sage-2.9.1 to sage-2.8.12

comment:3 Changed 13 years ago by robertwb

  • Owner changed from was to robertwb
  • Status changed from new to assigned

Changed 13 years ago by robertwb

comment:4 Changed 13 years ago by robertwb

  • Summary changed from is_trivial() does not work for fractional ideals of number field to [with patch] is_trivial() does not work for fractional ideals of number field

Changed 13 years ago by ncalexan

comment:5 Changed 13 years ago by ncalexan

Both patches above should be applied: Robert's handles the special case of number fields; mine fixes a bug in multipolynomial ideals and makes generic ideals more robust.

comment:6 Changed 13 years ago by mabshoff

  • Milestone changed from sage-2.9 to sage-2.8.13

comment:7 Changed 13 years ago by was

GOOD -- I especially like Nick's improvements.

comment:8 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.8.13.alpha1.

Note: See TracTickets for help on using tickets.