Opened 13 years ago

Closed 13 years ago

#8045 closed defect (fixed)

add elliptic integrals to the reference manual

Reported by: John Palmieri Owned by: Minh Van Nguyen
Priority: minor Milestone: sage-4.3.2
Component: documentation Keywords:
Cc: Merged in: sage-4.3.2.rc0
Authors: John Palmieri Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The documentation strings for classes like elliptic_ec are contained in their __init__ methods, and so doesn't show up in the reference manual. This patch fixes that by moving the documentation to the class definition.

Attachments (4)

trac_8045-elliptic.patch (6.0 KB) - added by John Palmieri 13 years ago.
trac_8045-elliptic.2.patch (6.3 KB) - added by Mitesh Patel 13 years ago.
Some cleanups. Replaces previous.
trac_8045-elliptic-v3.patch (6.2 KB) - added by John Palmieri 13 years ago.
replaces all previous patches
trac_8045-delta.patch (987 bytes) - added by John Palmieri 13 years ago.
difference between versions 2 and 3, for reference purposes only. don't merge.

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by John Palmieri

Attachment: trac_8045-elliptic.patch added

comment:1 Changed 13 years ago by John Palmieri

Status: newneeds_review

Changed 13 years ago by Mitesh Patel

Attachment: trac_8045-elliptic.2.patch added

Some cleanups. Replaces previous.

comment:2 Changed 13 years ago by Mitesh Patel

Reviewers: Mitesh Patel

V2 makes the docstrings more consistent and fixes a mistake (I think) in elliptic_pi's docstring. For comparison, see Maxima's documentation and MathWorld.

Positive review, if my changes are OK.

comment:3 Changed 13 years ago by John Palmieri

Status: needs_reviewpositive_review

We both missed two typos. Here's version 3, plus a delta patch to see the (essentially trivial) differences.

Changed 13 years ago by John Palmieri

Attachment: trac_8045-elliptic-v3.patch added

replaces all previous patches

Changed 13 years ago by John Palmieri

Attachment: trac_8045-delta.patch added

difference between versions 2 and 3, for reference purposes only. don't merge.

comment:4 Changed 13 years ago by Mitesh Patel

Oops. Thanks for catching the typos.

comment:5 Changed 13 years ago by Minh Van Nguyen

Merged in: sage-4.3.2.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.