Opened 13 years ago

Closed 13 years ago

#8028 closed enhancement (fixed)

Improvements to element_wrapper

Reported by: Nicolas M. Thiéry Owned by: Sage Combinat CC user
Priority: major Milestone: sage-4.3.2
Component: combinatorics Keywords: ElementWrapper, partial order
Cc: Merged in: sage-4.3.2.alpha0
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Nicolas M. Thiéry)

Improvements to element_wrapper:

  • Do not define cmp by default to not force a total order on subclasses
  • Define lt to have elements incomparable by default
  • Provide alternative implementations as _cmp_by_value, _lt_by_value
  • Update accordingly:
  • Misc polishing (copyright header, whitespace, ...)

This will be used by upcoming patches for crystals, ...

Attachments (1)

trac_8028_element_wrapper-improvement-nt.patch (8.6 KB) - added by Nicolas M. Thiéry 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Nicolas M. Thiéry

comment:1 Changed 13 years ago by Nicolas M. Thiéry

Description: modified (diff)
Status: newneeds_review

comment:2 in reply to:  1 Changed 13 years ago by Florent Hivert

Status: needs_reviewpositive_review

Everything ok !

comment:3 Changed 13 years ago by Minh Van Nguyen

Merged in: sage-4.3.2.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.