Opened 7 years ago

Closed 7 years ago

#8028 closed enhancement (fixed)

Improvements to element_wrapper

Reported by: nthiery Owned by: sage-combinat
Priority: major Milestone: sage-4.3.2
Component: combinatorics Keywords: ElementWrapper, partial order
Cc: Merged in: sage-4.3.2.alpha0
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by nthiery)

Improvements to element_wrapper:

  • Do not define cmp by default to not force a total order on subclasses
  • Define lt to have elements incomparable by default
  • Provide alternative implementations as _cmp_by_value, _lt_by_value
  • Update accordingly:
  • Misc polishing (copyright header, whitespace, ...)

This will be used by upcoming patches for crystals, ...

Attachments (1)

trac_8028_element_wrapper-improvement-nt.patch (8.6 KB) - added by nthiery 7 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 follow-up: Changed 7 years ago by nthiery

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 in reply to: ↑ 1 Changed 7 years ago by hivert

  • Status changed from needs_review to positive_review

Everything ok !

comment:3 Changed 7 years ago by mvngu

  • Merged in set to sage-4.3.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.