Opened 7 years ago

Closed 7 years ago

#8001 closed enhancement (fixed)

Stronger category tests

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3.2
Component: doctest coverage Keywords: TestSuite, Category
Cc: sage-combinat Merged in: sage-4.3.2.alpha0
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

  • More category tests: _test_category, _test_elements
  • Improvements to TestSuite?
    • Partial support for nested test suites
    • Support for basic TestSuite?(x) for x any Python object
  • Added TestSuite? call for Spec and ref to #7946
  • Corresponding doctest updates

Depends on #7921

Attachments (2)

trac_8001-categories_testsuite-nt.patch (64.3 KB) - added by nthiery 7 years ago.
trac_8001-categories_testsuite-review-fh.patch (1.7 KB) - added by hivert 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by nthiery

comment:1 follow-up: Changed 7 years ago by nthiery

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by robertwb

I briefly glanced at the patch when doing #7921, and what I saw looks good (though I didn't read it all thoroughly enough to call it a review).

comment:3 in reply to: ↑ 1 ; follow-up: Changed 7 years ago by hivert

I'm uploading a small trivial review patch. Here are the comment:

  • Add a missing "`";
  • Improve the layout of an enumeration;
  • replace ZZ._tester with QQ._tester to show that the gadget is automatically attached (Noting to do with the previous call on ZZ.

Otherwise the patch is ready to go.

Nicolas: You can add positive review once you had a look on my review patch.

comment:4 in reply to: ↑ 3 Changed 7 years ago by nthiery

  • Status changed from needs_review to positive_review

Replying to hivert:

I'm uploading a small trivial review patch. Here are the comment:

  • Add a missing "`";
  • Improve the layout of an enumeration;
  • replace ZZ._tester with QQ._tester to show that the gadget is automatically attached (Noting to do with the previous call on ZZ.

Otherwise the patch is ready to go.

Thanks for the review!

Nicolas: You can add positive review once you had a look on my review patch.

Done!

comment:5 Changed 7 years ago by mvngu

  • Merged in set to sage-4.3.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.