Opened 10 years ago
Closed 10 years ago
#8000 closed defect (fixed)
Add # -*- coding: utf-8 -*- to the top of all SageNB .py files
Reported by: | mpatel | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.2 |
Component: | notebook | Keywords: | |
Cc: | timdumol, mvngu | Merged in: | sagenb-0.7 |
Authors: | Tim Dumol | Reviewers: | Mitesh Patel |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Adding the pragma now to all Python files in SageNB may prevent some of the increasingly common docbuild errors raised when we build the reference manual.
Attachments (3)
Change History (13)
comment:1 follow-ups: ↓ 2 ↓ 3 Changed 10 years ago by
comment:2 in reply to: ↑ 1 Changed 10 years ago by
comment:3 in reply to: ↑ 1 Changed 10 years ago by
Replying to mpatel:
Minh -- Is this OK? Shall we make another ticket to update the whole Sage library?
I'm not sure about this, although I can clearly see the benefit of it. On the one hand, this could be further discouragement to people who want to start with Sage development. Could you send an email to sage-devel polling people about this issue? I mean something along the line of, "Should each source file have the character encoding preamble # -*- coding: utf-8 -*- ?". Also see #7999 relating to one file in the Sage library.
comment:4 Changed 10 years ago by
- Description modified (diff)
Actually, it seems that # -*- coding: utf-8 -*-
was already at the top of worksheet.py
.
comment:5 follow-up: ↓ 6 Changed 10 years ago by
Perhaps a different coding slipped in?
comment:6 in reply to: ↑ 5 Changed 10 years ago by
comment:7 follow-up: ↓ 8 Changed 10 years ago by
- Status changed from new to needs_review
This patch should do the trick.
comment:8 in reply to: ↑ 7 Changed 10 years ago by
- Reviewers set to Mitesh Patel
- Status changed from needs_review to positive_review
Replying to timdumol:
This patch should do the trick.
It does, indeed. V2 also fixes a failed doctest in sagenb.misc.sageinspect.
comment:9 Changed 10 years ago by
V3 is rebased for this queue (patch version numbers may be off by one):
sagenb-0.6 trac_7249-jinja2_v9.5.patch trac_7962-link-worksheets-zip-file.patch trac_7969-escaped-backslash.patch trac_4217-html-system-formatting.3.patch trac_3083-print-documentation.5.patch trac_6182-double-quotes-ws.2.patch trac_5263-publish-url.patch trac_7631-republish-name.patch trac_6353-cookies-diff-ports.patch trac_7207-sagenb-future-import.3.patch trac_8000-utf-8-coding-directive.2.patch
comment:10 Changed 10 years ago by
- Merged in set to sagenb-0.7
- Resolution set to fixed
- Status changed from positive_review to closed
Minh -- Is this OK? Shall we make another ticket to update the whole Sage library?