Opened 14 years ago

Closed 10 years ago

#800 closed enhancement (duplicate)

make _sig_on and _sig_off faster when stacked

Reported by: craigcitro Owned by: malb
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers: Mariah Lenox
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Gonzalo brought up the following very good idea: one should rewrite the code for _sig_on and _sig_off to keep a counter of how many _sig_on calls it has seen, and run less than the full amount of code (i.e. nothing involving system calls) if we've already had a _sig_on. Then _sig_off can just decrement the counter, and only do the "real work" if it's being decremented to zero.

Change History (7)

comment:1 Changed 14 years ago by was

  • Milestone changed from sage-2.8.6 to sage-2.9

comment:2 Changed 12 years ago by malb

  • Type changed from defect to enhancement

comment:3 Changed 12 years ago by malb

  • Owner changed from tornaria to malb
  • Status changed from new to assigned

comment:4 Changed 11 years ago by jdemeyer

  • Report Upstream set to N/A

This should be implemented as part of #9678.

comment:5 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.6.2 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Fixed by #9678.

comment:6 Changed 10 years ago by mariah

  • Reviewers set to Mariah Lenox
  • Status changed from needs_review to positive_review

If this is a sage-duplicate/invalid/wontfix, then I believe this ticket can be closed.

comment:7 Changed 10 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.