Opened 13 years ago

Closed 13 years ago

#7999 closed defect (fixed)

SyntaxError when loading Sage 4.3.1.rc1 due to non-ASCII character

Reported by: mvngu Owned by: tbd
Priority: minor Milestone: sage-4.3.1
Component: misc Keywords:
Cc: Merged in: sage-4.3.1.rc2
Authors: Minh Van Nguyen Reviewers: Mitesh Patel
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mvngu)

I built Sage 4.3.1.rc1 from source and then produced a sage.math binary. Loading the binary resulted in the following SyntaxError:

SyntaxError: Non-ASCII character '\xc3' in file /dev/shm/mvngu/sage-4.3.1.rc1-dev/local/lib/python2.6/site-packages/sage/schemes/elliptic_curves/ell_rational_field.py on line 5448, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details (ell_rational_field.py, line 5447)
Error importing ipy_profile_sage - perhaps you should run %upgrade?
WARNING: Loading of ipy_profile_sage failed.

The guilty line is line 5447:

           modular forms. Astérisque, (295):ix, 117-290, 2004.                  

of sage/schemes/elliptic_curves/ell_rational_field.py, which doesn't have the following preamble to indicate that the file has non-ASCII characters:

# -*- coding: utf-8 -*-

See this wiki page for information on dealing with non-ASCII characters in source files.

Attachments (1)

trac_7999-encoding.patch (582 bytes) - added by mvngu 13 years ago.
based on Sage 4.3.1.rc1

Download all attachments as: .zip

Change History (4)

comment:1 Changed 13 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Description modified (diff)
  • Status changed from new to needs_review

Changed 13 years ago by mvngu

based on Sage 4.3.1.rc1

comment:2 Changed 13 years ago by mpatel

  • Reviewers set to Mitesh Patel
  • Status changed from needs_review to positive_review

comment:3 Changed 13 years ago by rlm

  • Merged in set to sage-4.3.1.rc2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.