Opened 8 years ago

Closed 8 years ago

#7992 closed defect (fixed)

typo in sage/libs/mwrank/interface.py

Reported by: rlm Owned by: cremona
Priority: minor Milestone:
Component: elliptic curves Keywords:
Cc: Merged in: sage-4.3.1.rc2
Authors: John Cremona Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

A 2-descent didn't not complete successfully

Attachments (2)

trac_7992-typo.patch (798 bytes) - added by cremona 8 years ago.
Applies to 4.3.1.rc0
trac_7992-typo.2.patch (1.4 KB) - added by cremona 8 years ago.
replaces previous

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by cremona

Applies to 4.3.1.rc0

comment:1 Changed 8 years ago by cremona

  • Status changed from new to needs_work

Patch attached. As far as I can see this message does not appear in a doctest. Which means that I should add a doctest for it, hence not ready for review yet.

Changed 8 years ago by cremona

replaces previous

comment:2 Changed 8 years ago by cremona

  • Authors set to John Cremona
  • Priority changed from major to minor
  • Status changed from needs_work to needs_review

New patch adds doctest (one showing failure and one ok).

I don't know why the output of the RuntimeError? does not include the string (the one where the typo was fixed). Maybe the review does?

comment:3 Changed 8 years ago by rlm

  • Reviewers set to Robert Miller
  • Status changed from needs_review to positive_review

comment:4 Changed 8 years ago by rlm

  • Merged in set to sage-4.3.1.rc2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.