Changes between Initial Version and Version 2 of Ticket #7978

Jan 25, 2010, 6:31:06 AM (13 years ago)
Anne Schilling

The patch trac_7978_crystal_cleanup-as.patch supersedes Jason's patch. It fixes the whitespace issues in combinat/crystals/ and does a lot more improvements in crystals (see description).


  • Ticket #7978

    • Property Status changed from new to needs_review
    • Property Authors changed from to Nicolas M. Thiery, Anne Schilling
    • Property Summary changed from The file sage/combinat/ contains lots of 'tab' characters to Cleanup of crystal code
    • Property Keywords crystals added
    • Property Reviewers changed from to Dan Bump
  • Ticket #7978 – Description

    initial v2  
    1 They should be replaced with spaces.
     1Fixed some issues in crystals, such as
     2 - Comparison of elements
     3 - Latex output
     4 - Fixes whitespaces in /combinat/crystals/ (as reported by Jason Bandlow)
     5 - All crystals have unique representation
     6 - Preparation of categorification of crystals:
     7    - C.element_class -> C.Element
     8    - All crystals are at least in the EnumeratedSets category
     9    - Use rename, or define _repr_, instead of setting _name
     10      Eventually, crystals should only use _repr_
     11    => Removed dependency upon deprecated CombinatorialClass
     12 - Systematic use of TestSuite instead of loads/dumps test
     13 - Fixed bug in fast_crystal: delpat is not immutable (which should be
     14   eventually be fixed), and was accidentally changed by the weight
     15   method). This was caught by turning on unique representation which
     16   made the crystals to be reused longer in the tests.
     18Depends on trac ticket 8028 (element wrapper improvement)