Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#7971 closed defect (duplicate)

Change all occurrences of "method" to "algorithm" in coding/code_bounds.py

Reported by: rbeezer Owned by: wdj
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: coding theory Keywords:
Cc: wdj Merged in:
Authors: Rob Beezer Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is a follow-on to #6094. More places where the keyword argument "method=" should be changed to "algorithm=".

Attachments (1)

trac_7971_method_algorithm.patch (3.9 KB) - added by rbeezer 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc wdj added

This patch will build, and the tests in sage/coding all pass. But I don't have Guava installed, which is needed for most of the affected doctests.

David - maybe you can run the optional tests as part of a review?

Changed 11 years ago by rbeezer

comment:2 Changed 11 years ago by rbeezer

  • Status changed from new to needs_review

comment:3 Changed 11 years ago by mvngu

  • Reviewers set to Minh Van Nguyen
  • Status changed from needs_review to positive_review

Passes all doctests on Sage 4.3.1.rc0 with or without the patch. To run the optional doctests that require Guava: After applying the patch, install the optional Guava package by installing the package gap_packages-4.4.10_6.spkg. Running doctest on "sage/coding/code_bounds.py" with the options

-t -long -optional

results in all doctests passed. Positive review.

comment:4 Changed 11 years ago by rbeezer

  • Status changed from positive_review to needs_work

This needs work (deprecation warnings) and so should just be handled as part of #6094.

I've marked this as "needs work" but should be marked some form of invalid.

comment:5 Changed 10 years ago by jsrn

The currently newest uploaded patch for Trac #6094 -- needing a positive review -- handles all these cases, so this Trac should just be closed.

comment:6 Changed 10 years ago by rlm

  • Resolution set to duplicate
  • Status changed from needs_work to closed

comment:7 Changed 10 years ago by mvngu

  • Milestone changed from sage-4.6.1 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.