Opened 11 years ago

Closed 11 years ago

Last modified 4 years ago

#7967 closed defect (fixed)

DeprecationWarning for popen3 in hg_sage

Reported by: wjp Owned by: tbd
Priority: major Milestone: sage-4.3.1
Component: misc Keywords:
Cc: Merged in: sage-4.3.1.rc1
Authors: Willem Jan Palenstijn Reviewers: Tim Dumol
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Using hg_sage is raising a DeprecationWarning: 

/data/sage/sage-4.3.1.rc0/local/lib/python2.6/site-packages/sage/misc/hg.py:240: DeprecationWarning: os.popen3 is deprecated.  Use the subprocess module.
  x = os.popen3(s)

Attachments (1)

7967_popen3.patch​ (1.7 KB) - added by wjp 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by wjp

  • Milestone set to sage-4.3.1
  • Status changed from new to needs_review

Changed 11 years ago by wjp

comment:2 Changed 11 years ago by timdumol

  • Authors set to Willem Palenstijn
  • Reviewers set to Tim Dumol
  • Status changed from needs_review to positive_review

Good job; looks good.

comment:3 Changed 11 years ago by rlm

  • Merged in set to sage-4.3.1.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 4 years ago by chapoton

  • Authors changed from Willem Palenstijn to Willem Jan Palenstijn
Note: See TracTickets for help on using tickets.