Opened 11 years ago

Closed 11 years ago

#7963 closed defect (fixed)

Downloading multiple worksheets does not work

Reported by: jason Owned by: was
Priority: major Milestone: sage-4.3.2
Component: notebook Keywords:
Cc: timdumol, jason Merged in: sagenb-0.7
Authors: Mitesh Patel Reviewers: Alex Leone
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jason)

I do the following:

  1. Start the notebook with notebook()
  1. click the checkboxes next to a few worksheets
  1. hit the "Download" button

and I get an error:

The resource /download_worksheets?filenames=admin/77___S_A_G_E___admin/76___S_A_G_E___admin/75___S_A_G_E___&sep=___S_A_G_E___ cannot be found.

Attachments (1)

trac_7963-download-multiple-worksheets.patch (770 bytes) - added by timdumol 11 years ago.
Adds mpatel's suggested fix.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by jason

  • Description modified (diff)

comment:2 Changed 11 years ago by mpatel

I think this is a matter of

  • sagenb/data/sage/js/notebook_lib.js

    a b function download_worksheets_button() { 
    15151515    /*
    15161516    Downloads the set of checked worksheets as a zip file.
    15171517    */
    1518     window.location.replace("/download_worksheets?filenames=" +
     1518    window.location.replace("/download_worksheets.zip?filenames=" +
    15191519                            checked_worksheet_filenames() + "&sep=" + SEP);
    15201520}

but I haven't posted a patch, since #7908 and some of its dependencies make a lot of changes to notebook_lib.js.

Changed 11 years ago by timdumol

Adds mpatel's suggested fix.

comment:3 Changed 11 years ago by timdumol

  • Cc jason added
  • Status changed from new to needs_review

This adds what mpatel suggested.

comment:4 Changed 11 years ago by mpatel

Thanks for making a patch! It works for me, but I'm not sure I should review this by myself.

comment:5 Changed 11 years ago by acleone

  • Authors set to Mitesh Patel
  • Reviewers set to Alex Leone
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 11 years ago by mvngu

  • Milestone set to sage-4.3.2

comment:7 Changed 11 years ago by mpatel

  • Merged in set to sagenb-0.7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.