Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#7961 closed defect (fixed)

Make recognition of runpath/develpath in editmodule more robust

Reported by: nbruin Owned by: nbruin
Priority: major Milestone: sage-4.3.1
Component: misc Keywords:
Cc: Merged in: sage-4.3.1.rc1
Authors: Nils Bruin Reviewers: Tim Dumol
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Currently, the code that recognizes a source file is part of the sage library and hence is run from a different location than where the edit copy lives, is broken due to the python2.5 -> python2.6 upgrade. Attached fixes this problem and makes matching more robust so that it won't break the next time. To illustrate the problem, currently we have

sage: sage.misc.edit_module.file_and_line(edit)
('/usr/local/sage/4.3/local/lib/python2.6/site-packages/sage/misc/edit_module.py', 194)

which obviously is NOT the file to edit. It should be .../sage/devel/... instead. Attached patch fixes this.

Attachments (1)

edit_module.patch (1.4 KB) - added by nbruin 12 years ago.
making misc.edit_module pathname mangling more robust

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by nbruin

making misc.edit_module pathname mangling more robust

comment:1 Changed 12 years ago by nbruin

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by timdumol

  • Reviewers set to Tim Dumol
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 12 years ago by rlm

  • Merged in set to sage-4.3.1.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 12 years ago by mhansen

  • Milestone changed from sage-4.3.2 to sage-4.3.1
Note: See TracTickets for help on using tickets.