Opened 12 years ago

Closed 3 years ago

Last modified 3 years ago

#7960 closed enhancement (invalid)

QQbar should accept number field elements with embeddings

Reported by: robertwb Owned by: was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: number theory Keywords:
Cc: vdelecroix Merged in:
Authors: Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

One should be able to do

sage: K.<a> = NumberField(x^3-x+1, embedding=-1.32)
sage: QQbar(a)
-1.324717957244746?

Followup to #4621

Change History (11)

comment:1 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 7 years ago by vdelecroix

  • Cc vdelecroix added

cc'ing me.

The function sage.rings.number_field.number_field_morphisms.create_embedding_from_approx should really be smarter. This is related to what I am currently doing in #17830.

comment:6 Changed 3 years ago by mmezzarobba

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix

Fixed in #13041.

comment:7 Changed 3 years ago by mkoeppe

  • Status changed from new to needs_review

comment:8 follow-up: Changed 3 years ago by pbruin

The requested example now works. It would be even nicer to also have a coercion map from K to QQbar, but currently we do not have this:

sage: K.<a> = NumberField(x^3 - x + 1, embedding=-1.32)
sage: QQbar(a)
-1.324717957244746?
sage: QQbar.coerce_map_from(K) is None
True

comment:9 in reply to: ↑ 8 Changed 3 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

Replying to pbruin:

It would be even nicer to also have a coercion map from K to QQbar

OK, there is already a ticket for this: #5355. Positive review for this one.

comment:10 Changed 3 years ago by embray

  • Resolution set to invalid
  • Status changed from positive_review to closed

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

comment:11 Changed 3 years ago by slelievre

  • Description modified (diff)

Just fixing the example in the ticket description so anyone can check this now works.

Note: See TracTickets for help on using tickets.