Opened 10 years ago

Closed 10 years ago

#7909 closed defect (fixed)

Replace $MKDIR with 'mkdir' in sage-spkg

Reported by: drkirkby Owned by: GeorgSWeber
Priority: major Milestone: sage-4.3.1
Component: build Keywords:
Cc: jsp Merged in: sage-4.3.1.rc0
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jsp)

sage-spkg has $MKDIR in one place, which will cause problems with an updated 'sage-env' which no longer defines MKDIR.

I'm attaching a copy of the revised sage-spkg, and also a Mercurial patch.

Attachments (2)

sage-spkg (12.1 KB) - added by drkirkby 10 years ago.
A complete copy of the revised sage-env
sage-spkg-remove-MKDIR.patch (547 bytes) - added by drkirkby 10 years ago.
Mercurial patch for sage-env

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by drkirkby

A complete copy of the revised sage-env

Changed 10 years ago by drkirkby

Mercurial patch for sage-env

comment:1 Changed 10 years ago by drkirkby

  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by jsp

  • Reviewers set to Jaap Spies

Don't know whether the name 'sage-spkg' is any good. Did you mean to attach the new sage-env?

The patch is simple and looks good.

Jaap

comment:3 in reply to: ↑ 2 Changed 10 years ago by jsp

  • Description modified (diff)

Replying to jsp:

Don't know whether the name 'sage-spkg' is any good. Did you mean to attach the new sage-env?

The patch is simple and looks good.

Jaap

It is really in sage-spkg!! I changed the description.

Waiting for the mercurial patch.

Jaap

comment:4 Changed 10 years ago by jsp

  • Status changed from needs_review to positive_review

The "mercurial patch" is ok. sage-spkg looks good. So positive review.

Jaap

comment:5 Changed 10 years ago by rlm

  • Merged in set to sage-4.3.1.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.