Opened 13 years ago

Closed 13 years ago

#7901 closed defect (fixed)

Change $MKDIR to 'mkdir' in pari

Reported by: David Kirkby Owned by: Georg S. Weber
Priority: major Milestone: sage-4.3.1
Component: build Keywords:
Cc: Jaap Spies, John Palmieri Merged in: sage-4.3.1.rc0
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by David Kirkby)

It was agreed recently that variables would not be used for very common commands like MV, MKDIR etc.

http://groups.google.com/group/sage-devel/browse_thread/thread/bd7ae07a1157bead/970aa0dc8fa56ab7?lnk=raot

#7818 usets these, so this package may break. The fix is to simply replace $MKDIR with 'mkdir' in spkg-install.

An updated .spkg can be found at

http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg

Attachments (1)

pari-variables-to-commands.patch (1.6 KB) - added by David Kirkby 13 years ago.
Updated patch to fix spkg-install and SPKG.txt

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by David Kirkby

Authors: David Kirkby
Status: newneeds_review

comment:2 Changed 13 years ago by David Kirkby

Description: modified (diff)

comment:3 Changed 13 years ago by Jaap Spies

Reviewers: Jaap Spies

The patch of spkg-install looks ok. Maybe the SPKG.txt should be brought up to date.

See also: http://trac.sagemath.org/sage_trac/ticket/7738

Dave, can you fix that?

Jaap

comment:4 Changed 13 years ago by David Kirkby

OK I've recreated the spkg, which again can be found at http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg Please check it again.

I've attached the Mercurial patch, which overwrites the old one.

Changed 13 years ago by David Kirkby

Updated patch to fix spkg-install and SPKG.txt

comment:5 Changed 13 years ago by Jaap Spies

Status: needs_reviewpositive_review

All fixed. Positive review.

Jaap

comment:6 Changed 13 years ago by Robert Miller

Merged in: sage-4.3.1.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.