Opened 13 years ago

Closed 13 years ago

#7900 closed defect (fixed)

Replace variables like $RM with 'rm' in Mercurial

Reported by: David Kirkby Owned by: Georg S. Weber
Priority: major Milestone: sage-4.3.1
Component: build Keywords:
Cc: Jaap Spies, John Palmieri Merged in: sage-4.3.1.rc0
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

It was agreed recently that variables would not be used for very common commands like MV, MKDIR etc.

http://groups.google.com/group/sage-devel/browse_thread/thread/bd7ae07a1157bead/970aa0dc8fa56ab7?lnk=raot

#7818 usets these, so this package will break. The fix is to simply replace things like

$LN with 'ln'

An updated .spkg can be found at

http://boxen.math.washington.edu/home/kirkby/portability/mercurial-1.3.1.p1/mercurial-1.3.1.p1.spkg

Attachments (1)

mercurial-variables-to-commands.patch (1.5 KB) - added by David Kirkby 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by David Kirkby

comment:1 Changed 13 years ago by David Kirkby

Status: newneeds_review

comment:2 Changed 13 years ago by David Kirkby

Cc: John Palmieri added

comment:3 Changed 13 years ago by Jaap Spies

Reviewers: Jaap Spies
Status: needs_reviewpositive_review

The new package looks good. Positive review.

Jaap

comment:4 Changed 13 years ago by Robert Miller

Merged in: sage-4.3.1.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.