Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7888 closed defect (duplicate)

Do not pass comment lines to Macaulay2

Reported by: novoselt Owned by: was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: Merged in:
Authors: Andrey Novoseltsev Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges


Currently passing "pure comments" to Macaulay2 locks the interface since Macaulay2 does not print a new input prompts. Evaluating whitespace lines locks it as well and while there is some stripping code in Expect, it does not work if whitespace lines appear in the middle of a block.

The attached patch replaces all such lines with empty ones before passing to Macaulay2. This may break string constants occupying several lines, however, as far as I understand, they have no chance of working without substantial modification of Expect.eval, which currently executes code line by line. (In particular, they hang up now.)

Attachments (1)

do_not_pass_comment_lines_to_Macaulay2.patch (1.7 KB) - added by novoselt 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by novoselt

comment:1 Changed 11 years ago by novoselt

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by novoselt

  • Resolution set to duplicate
  • Status changed from needs_review to closed

Ticket #7897 fixes this in a better way.

comment:3 Changed 11 years ago by mvngu

  • Milestone set to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.