Opened 10 years ago

Closed 9 years ago

#7880 closed enhancement (fixed)

Category of sets with partial maps.

Reported by: robertwb Owned by: nthiery
Priority: major Milestone: sage-4.4
Component: categories Keywords:
Cc: Merged in: sage-4.4.alpha0
Authors: David Roe Reviewers: Robert Bradshaw, David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

In support of #7585 and Tate's algorithm over function fields.

Attachments (2)

7585_4_sets_with_partial_maps.patch (13.8 KB) - added by robertwb 10 years ago.
trac_7880-sets_with_partial_maps.patch (14.0 KB) - added by davidloeffler 10 years ago.
replaces previous patch

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by robertwb

comment:1 Changed 10 years ago by robertwb

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by robertwb

  • Status changed from needs_review to positive_review

Looks good.

comment:3 Changed 10 years ago by nthiery

  • Status changed from positive_review to needs_work

I am not convinced about the name, which suggests at first that the objects are Sets with more structure, not less. I don't have a better suggestion though. If nobody comes up with something better (ObjectsWith????) in a day or two, just put back a positive review.

comment:4 Changed 10 years ago by nthiery

  • Status changed from needs_work to needs_info

comment:5 Changed 10 years ago by roed

  • Milestone changed from sage-4.3.4 to sage-4.3.3
  • Status changed from needs_info to needs_review

This is needed for the series of patches starting at 8218. I agree that the name is not optimal, but nobody's come up with a better one in 6 weeks...

comment:6 Changed 10 years ago by roed

  • Milestone changed from sage-4.3.3 to sage-4.3.4

comment:7 Changed 10 years ago by roed

Part of a series:

8218 -> 8332 -> 7880 -> 7883 -> 8333 -> 8334 -> 8335

I tried to make each of these mostly self contained, with doctests passing after every ticket, but I didn't entirely succeed. If you're reviewing one of these tickets, applying later tickets will hopefully fix doctest failures that you're seeing.

Changed 10 years ago by davidloeffler

replaces previous patch

comment:8 Changed 10 years ago by davidloeffler

  • Reviewers changed from Robert Bradshaw to Robert Bradshaw, David Loeffler
  • Status changed from needs_review to positive_review

Looks good to me. I've made some tiny doctest fixes, and uploaded a new version of the patch, still with roed's user stamp on it. This applies cleanly to 4.3.4.rc0, if you apply the patches in the following order:

$ sage -hg qseries
trac_8218_fixes_434alpha1.patch
trac_8332_givaro_python.patch
trac_8332_reviewer.patch
trac_7880-sets_with_partial_maps.patch

on top of the patches at #8218 and #8332.

comment:9 Changed 9 years ago by nthiery

Oh, just one thing: are objects in SetsWithPartialMaps? parents or not?

comment:10 Changed 9 years ago by jhpalmieri

  • Merged in set to sage-4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

Merged "trac_7880-sets_with_partial_maps.patch" in 4.4.alpha0

Note: See TracTickets for help on using tickets.