Opened 11 years ago
Closed 11 years ago
#7835 closed defect (fixed)
Preparsing on server does not account for unicode text
Reported by: | timdumol | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.1 |
Component: | notebook | Keywords: | |
Cc: | was, mpatel, ddrake | Merged in: | sagenb-0.6 |
Authors: | Tim Dumol | Reviewers: | Mitesh Patel |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Attachments (2)
Change History (12)
comment:1 Changed 11 years ago by
- Cc was mpatel added
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
This looks good to me. Is there a simple example that breaks the existing code?
comment:3 Changed 11 years ago by
You mean without this patch? Just use any non-ASCII character and attempt to evalaute it.
print 'é'
comment:4 Changed 11 years ago by
Just to check: I should apply #7249, too. Otherwise, even with this patch, print 'é'
raises
File "/home/sage/notebook/sagenb-0.4.9/sagenb/notebook/twist.py", line 1205, in render max_out=HISTORY_MAX_OUTPUT) exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 17: ordinal not in range(128)
at least for me.
comment:5 Changed 11 years ago by
Now reviewing #7249...
comment:6 Changed 11 years ago by
- Cc ddrake added
- Status changed from needs_review to needs_work
comment:7 Changed 11 years ago by
- Reviewers set to Mitesh Patel
- Status changed from needs_work to needs_review
V2 wraps the problem above in a try-except
block, for now, i.e., until #7249 takes hold. My review is positive, but someone should review my change.
comment:8 Changed 11 years ago by
- Status changed from needs_review to positive_review
comment:9 Changed 11 years ago by
I'm assuming my change is OK, given its position, but feel free to revert the status.
comment:10 Changed 11 years ago by
- Merged in set to sagenb-0.6
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This should do the trick.