Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7814 closed defect (fixed)

eclib ignores SAGE64 if OS is not Darwin

Reported by: David Kirkby Owned by: David Kirkby
Priority: major Milestone: sage-4.3.1
Component: porting Keywords:
Cc: Merged in: sage-4.3.1.alpha2
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

eclib-20080310.p7 suffered the usual problem of many packages - SAGE64 was ignored unless the operating system was OS X. This trivial patch simply ensure SAGE64 is not ignored on any platform.

I've checked in the changes with 'hg'

See: http://boxen.math.washington.edu/home/kirkby/portability/eclib-20080310.p8/

Change History (16)

comment:1 Changed 13 years ago by Jaap Spies

Reviewers: Jaap Spies
Status: newneeds_work

I think the wrong spkg is in this link.

Jaap

comment:2 Changed 13 years ago by Jaap Spies

I see:

if [ "$SAGE64" = "yes" ]; then
    echo "64 bit MacIntel build"
    DYN_FLAGS="-m64"; export DYN_FLAGS
    PICFLAG="-m64 -fPIC"
fi
export PICFLAG

in spkg-install

Jaap

comment:3 Changed 13 years ago by David Kirkby

yes, I should have removed that comment about the MacIntel?. I think you will find it does build, but I will remove that command and make a new package.

comment:4 Changed 13 years ago by Jaap Spies

If there is a new spkg (see above) I can give it a positive review. Tested on Fedora 12 and Open Solaris 32 bit

real	4m15.073s
user	3m35.053s
sys	0m24.029s
Successfully installed eclib-20080310.p8
You can safely delete the temporary build directory
/export/home/jaap/Downloads/sage-4.3/spkg/build/eclib-20080310.p8
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing eclib-20080310.p8.spkg
jaap@opensolaris:~/Downloads/sage-4.3$ 

After a successful install of ntl and pari.

Jaap

comment:5 Changed 13 years ago by David Kirkby

I've updated the package. It is now missing the comment that its a MacIntel?.

Please double check the package again though please - just in case I've messed up.

dave

comment:6 in reply to:  5 Changed 13 years ago by Jaap Spies

Replying to drkirkby:

I've updated the package. It is now missing the comment that its a MacIntel?.

Please double check the package again though please - just in case I've messed up.

dave

Sure,

Jaap

comment:7 Changed 13 years ago by Jaap Spies

Status: needs_workneeds_review

On Open Solaris:

real	4m8.443s
user	3m36.556s
sys	0m24.188s
Successfully installed eclib-20080310.p8

Looks good, build tested on Fedora 12 and Fedora 11.

Positive review.

Jaap

comment:8 Changed 13 years ago by Jaap Spies

Status: needs_reviewpositive_review

Couldn't change to positive review. Will do now.

Jaap

comment:9 Changed 13 years ago by David Kirkby

Summary: [with spkg; needs review] eclib ignores SAGE64 if OS is not Darwin[with spkg] eclib ignores SAGE64 if OS is not Darwin

Cheers.

I'm just going to remove the 'needs review from the title. I'm not sure if we are still supposed to do that or not. I find it easier to find me own sometime if its in the title. But anyway, I'm removing it now.

comment:10 Changed 13 years ago by Jaap Spies

Hi,

It already had a positive review, so ...?

Cheers,

Jaap

comment:11 Changed 13 years ago by Robert Miller

Merged in: 4.3.1.alpha2
Resolution: fixed
Status: positive_reviewclosed

comment:12 Changed 13 years ago by Minh Van Nguyen

Summary: [with spkg] eclib ignores SAGE64 if OS is not Darwineclib ignores SAGE64 if OS is not Darwin

comment:13 Changed 13 years ago by Minh Van Nguyen

Merged in: 4.3.1.alpha2sage-4.3.1.alpha2

comment:14 Changed 13 years ago by John Cremona

Dave, I only just noticed this ticket (from the Release Notes). I think you should have incereased the patch level from p8 to p9 - there now exist two different version s of the eclib spkg both called eclib-20080310.p8 which is rather confusing.

John

comment:15 Changed 13 years ago by David Kirkby

Looking at the diff file I made of the SPKG.txt

http://boxen.math.washington.edu/home/kirkby/portability/eclib-20080310.p8/SPKG.txt.diff

the last revision made was in

eclib-20080310.p7 (Michael Abshoff, October 12th, 2008)

  • Work around paralle make issue (#4228)

then I added

eclib-20080310.p8 (David Kirkby, 2nd January 2010)

  • Allow SAGE64 to work on all platforms, not just OS X.

Are you sure the previous one was patch level 8 and not 7? If it was, then SPKG.txt was not updated when it moved to 8. Sorry about that, if I did overlook this. I agree it is confusing, if this is so.

For it to also be merged, and the release manager not notice, seems a bit strange.

Dave

comment:16 Changed 13 years ago by John Cremona

What I found was this. On my own computer I have a p8 with the following changelog entry:

=== eclib-20080310.p8 (John Cremona, January 6th, 2009) ===
 * Change to debugging output in procs/p2points.cc (not relevant for Sage)
 * Change to pdivs() in procs/marith.cc (not relevant for Sage)

Now, whatever that was about, it was not relevant for Sage (either referred to functions not used by anything wrapped in Sage, or under compiler options which Sage does not use), and presumably for that reason I did not make a ticket for it to replace the (then) standard p7 in Sage.

I guess the thing for me to do now is to make a p9 which has both the changes I made in my p8 and the ones you made, and get it into Sage. I have to keep the version of the source files which are used by Sage in sync with the versions I have, otherwise I'll go mad.

Note: See TracTickets for help on using tickets.