Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7807 closed defect (fixed)

region_plot does not pass extra arguments to show

Reported by: jason Owned by: was
Priority: major Milestone: sage-4.3.3
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers: Ross Kyprianou
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is inconsistent with other plotting functions.

sage: region_plot([x^2+y^2<1, x<y], (x,-2,2), (y,-2,2),aspect_ratio=1)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/home/grout/.sage/temp/tiny/2531/_home_grout__sage_init_sage_0.py in <module>()

/home/grout/downloads/sage-4.3/local/lib/python2.6/site-packages/sage/plot/misc.pyc in wrapper(*args, **kwds)
    136                 options['__original_opts'] = kwds
    137             options.update(kwds)
--> 138             return func(*args, **options)
    139 
    140         

TypeError: region_plot() got an unexpected keyword argument 'aspect_ratio'

Change History (5)

comment:1 Changed 10 years ago by jason

The patch at #8004 resolves this.

comment:2 Changed 10 years ago by jason

  • Status changed from new to needs_review

comment:3 Changed 10 years ago by rossk

  • Status changed from needs_review to positive_review
# works as advertised
sage: region_plot([x^2+y^2<1, x<y], (x,-2,2), (y,-2,2),aspect_ratio=1)  

# (Correctly) doesnt complain about a single function
sage: region_plot([x^2+y^2<1], (x,-2,2), (y,-2,2),aspect_ratio=1) 

# using many functions is ok
sage: region_plot([x^2+y^2<1, x<y, x>-1/2, y>0], (x,-2,2), (y,-2,2),aspect_ratio=1)

# displays a portion of the last example properly
sage: region_plot([x^2+y^2<1, x<y, x>-1/2, y>0], (x,0,2), (y,-2,2),aspect_ratio=1) 

# a little computer art - my picture of a whale ;-) 
sage: region_plot([x^2+y^2<10, y< sin(x)], (x,-5,5), (y,-4,4),aspect_ratio=1)

comment:4 Changed 10 years ago by mpatel

  • Resolution set to fixed
  • Status changed from positive_review to closed

Fixed by #8004.

comment:5 Changed 10 years ago by rossk

  • Reviewers set to Ross Kyprianou
Note: See TracTickets for help on using tickets.