#7804 closed defect (fixed)
Move mip_coin and mip_glpk to Sage
Reported by: | ncohen | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.1 |
Component: | numerical | Keywords: | |
Cc: | mvngu | Merged in: | sage-4.3.1.alpha2 |
Authors: | Nathann Cohen | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Hello !!
This patches moves the files mip_coin and mip_glpk to Sage. They are currently included in the packages CBC and GLPK and are a lot harder to work on because of this.
This patch copies them in sage/numerical/ and adds several lines to modules_list so that they will only be compiled if the corresponding packages are installed.
For the moment, the copies of these files included in the packages will not be removed, in order to preserve backward-compatibility : the users of earlier versions of Sage will then be able to keep using the same packages.
*Only the changes to file modules_list need to be reviewed -- mip_coin and mip_glpk are copies of what is included in the spkg and have already been checked ! This should be a short review :-) *
Attachments (1)
Change History (13)
comment:1 Changed 9 years ago by
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
- Component changed from algebra to numerical
- Milestone set to sage-4.3.1
comment:3 Changed 9 years ago by
- Description modified (diff)
comment:4 Changed 9 years ago by
- Summary changed from Move mipCoin and mipGlpk to Sage to Move mip_coin and mip_glpk to Sage
comment:5 Changed 9 years ago by
Changed 9 years ago by
comment:6 Changed 9 years ago by
I just modified it so that it is now independent from the huge changes going on in graph.py. Would it be possible to have this merged to the next release ? It would let me write another speed-up patch now that solve_glpk and solve_cbc are available ;-)
Nathann
comment:7 Changed 9 years ago by
- Merged in set to 4.3.1.alpha2
- Resolution set to fixed
- Reviewers set to Robert Miller
- Status changed from needs_review to closed
positive review
comment:8 Changed 9 years ago by
Yessssssssssss !! :-) Thanks !!!!
Nathann
comment:9 Changed 9 years ago by
- Merged in changed from 4.3.1.alpha2 to sage-4.3.1.alpha2
comment:10 Changed 9 years ago by
How did this get a positive review when the new pyx files have no doctests?
comment:11 Changed 9 years ago by
That's a good point-- I suppose my review was a bit rushed.
Nathann,
Do you want to make a separate ticket for making some doctests here, or would you prefer it if I just pull the patch back out?
I was curious and skimmed this patch for ~ 3 minutes and it "looks good" (not a positive review -- I didn't test it yet).