Opened 12 years ago
Last modified 7 years ago
#7792 needs_work defect
Improved docs and INI support at /interfaces/povray.py
Reported by: | slosoi | Owned by: | was |
---|---|---|---|
Priority: | trivial | Milestone: | sage-6.4 |
Component: | interfaces | Keywords: | povray |
Cc: | Merged in: | ||
Authors: | Sami Losoi | Reviewers: | mhampton, boothby |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
To improve docs of Povray, support for inifile.
Attachments (3)
Change History (14)
comment:1 Changed 12 years ago by
- Status changed from new to needs_info
comment:2 Changed 12 years ago by
- Status changed from needs_info to needs_review
comment:3 follow-up: ↓ 4 Changed 12 years ago by
Changed 12 years ago by
comment:4 in reply to: ↑ 3 Changed 12 years ago by
Replying to slosoi:
There are some bugs apparently in the width and height parameters in the changed code. The parameters F and P work differently as I expected.
The patch -file is old one. I will submit a new one after the compilation of Sage.
comment:5 Changed 12 years ago by
- Description modified (diff)
- Summary changed from Improved docs and added Width and Height at /interfaces/povray.py to Improved docs and INI support at /interfaces/povray.py
Changed 12 years ago by
Changed 12 years ago by
comment:6 Changed 12 years ago by
Why are you removing the docstring from the class definition?
comment:7 Changed 12 years ago by
- Reviewers set to mhampton, boothby
- Status changed from needs_review to needs_work
Somethings up with these patches. Both povray_doc.patch and povray_doc.2.patch are identical and won't apply on top of povray.py. Also, the file is missing class-level documentation and doctests, (as mhampton noted, you should move the file-level doc back) and nothing is doctested in the methods.
comment:8 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:9 Changed 8 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:10 Changed 8 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:11 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-6.4
There are some bugs apparently in the width and height parameters in the changed code. The parameters F and P work differently as I expected.