Opened 12 years ago

Last modified 7 years ago

#7792 needs_work defect

Improved docs and INI support at /interfaces/povray.py

Reported by: slosoi Owned by: was
Priority: trivial Milestone: sage-6.4
Component: interfaces Keywords: povray
Cc: Merged in:
Authors: Sami Losoi Reviewers: mhampton, boothby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slosoi)

To improve docs of Povray, support for inifile.

Attachments (3)

povray.py (2.2 KB) - added by slosoi 12 years ago.
povray_doc.2.patch (3.0 KB) - added by slosoi 12 years ago.
povray_doc.patch (3.0 KB) - added by slosoi 12 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by slosoi

  • Status changed from new to needs_info

comment:2 Changed 12 years ago by slosoi

  • Status changed from needs_info to needs_review

comment:3 follow-up: Changed 12 years ago by slosoi

There are some bugs apparently in the width and height parameters in the changed code. The parameters F and P work differently as I expected.

Changed 12 years ago by slosoi

comment:4 in reply to: ↑ 3 Changed 12 years ago by slosoi

Replying to slosoi:

There are some bugs apparently in the width and height parameters in the changed code. The parameters F and P work differently as I expected.

The patch -file is old one. I will submit a new one after the compilation of Sage.

comment:5 Changed 12 years ago by slosoi

  • Description modified (diff)
  • Summary changed from Improved docs and added Width and Height at /interfaces/povray.py to Improved docs and INI support at /interfaces/povray.py

Changed 12 years ago by slosoi

Changed 12 years ago by slosoi

comment:6 Changed 12 years ago by mhampton

Why are you removing the docstring from the class definition?

comment:7 Changed 12 years ago by boothby

  • Reviewers set to mhampton, boothby
  • Status changed from needs_review to needs_work

Somethings up with these patches. Both povray_doc.patch and povray_doc.2.patch are identical and won't apply on top of povray.py. Also, the file is missing class-level documentation and doctests, (as mhampton noted, you should move the file-level doc back) and nothing is doctested in the methods.

comment:8 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:9 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:10 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:11 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.