Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7788 closed enhancement (duplicate)

followup to #5396 (wrapping lcalc library)

Reported by: rishi Owned by: was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: number theory Keywords:
Cc: craigcitro, cremona, ylchapuy, robertwb Merged in:
Authors: rishi Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by cremona)

I am attaching patches which adds to the lcalc wrapping documentation that the derivatives loose about half the precision. There is additional documentation to guide how many dirichlet coefficients are needed, at least for computing near the real axis. (Depends on #5396)

Attachments (3)

minor_change_lcalc-1.patch​ (1.7 KB) - added by rishi 11 years ago.
minor_change_lcalc-2.patch​ (1.6 KB) - added by rishi 11 years ago.
minor_change_lcalc-combined.patch​ (2.8 KB) - added by rishi 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by rishi

Changed 11 years ago by rishi

Changed 11 years ago by rishi

comment:1 Changed 11 years ago by rishi

  • Status changed from new to needs_review

I finally figured out how to combine several commits

comment:2 Changed 11 years ago by cremona

  • Description modified (diff)
  • Summary changed from followup patch to #5396 to followup to #5396 (wrapping lcalc library)

comment:3 Changed 11 years ago by cremona

  • Status changed from needs_review to positive_review

I'm giving this a positive review, though the formatting of the docstrings in lcalc_Lfunction.pyx is not correct so that sphinx would choke on these. But at the moment this file is not included in the reference manual. So rather than delay the merging of the lcalc wrapping, it seems reasonable to pass this as is and create a new TODO ticket for that.

comment:4 Changed 11 years ago by cremona

  • Status changed from positive_review to needs_work

I don't think it's helpful to have this tagged as "positive review" when it depends on #5396 which is still being worked on. So I am switching it back to "needs work" and it can go to "needs review" after #5396 is positively reviewed.

comment:5 Changed 11 years ago by rishi

John,

I put a new spkg in ​#5396

I tested it on my computer and on sage.math. I believe this should work.

Rishi

comment:6 Changed 11 years ago by robertwb

  • Cc robertwb added

comment:7 Changed 11 years ago by rishi

  • Resolution set to fixed
  • Status changed from needs_work to closed

This patch is superseded by #8623. This ticket can be discarded.

comment:8 Changed 11 years ago by mhansen

  • Milestone changed from sage-4.5 to sage-duplicate/invalid/wontfix
  • Resolution changed from fixed to duplicate
Note: See TracTickets for help on using tickets.