#7788 closed enhancement (duplicate)
followup to #5396 (wrapping lcalc library)
Reported by: | rishi | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | number theory | Keywords: | |
Cc: | craigcitro, cremona, ylchapuy, robertwb | Merged in: | |
Authors: | rishi | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
I am attaching patches which adds to the lcalc wrapping documentation that the derivatives loose about half the precision. There is additional documentation to guide how many dirichlet coefficients are needed, at least for computing near the real axis. (Depends on #5396)
Attachments (3)
Change History (11)
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Description modified (diff)
- Summary changed from followup patch to #5396 to followup to #5396 (wrapping lcalc library)
comment:3 Changed 11 years ago by
- Status changed from needs_review to positive_review
I'm giving this a positive review, though the formatting of the docstrings in lcalc_Lfunction.pyx is not correct so that sphinx would choke on these. But at the moment this file is not included in the reference manual. So rather than delay the merging of the lcalc wrapping, it seems reasonable to pass this as is and create a new TODO ticket for that.
comment:4 Changed 11 years ago by
- Status changed from positive_review to needs_work
comment:5 Changed 11 years ago by
John,
I put a new spkg in #5396
I tested it on my computer and on sage.math. I believe this should work.
Rishi
comment:6 Changed 11 years ago by
- Cc robertwb added
comment:7 Changed 11 years ago by
- Resolution set to fixed
- Status changed from needs_work to closed
This patch is superseded by #8623. This ticket can be discarded.
comment:8 Changed 11 years ago by
- Milestone changed from sage-4.5 to sage-duplicate/invalid/wontfix
- Resolution changed from fixed to duplicate
I finally figured out how to combine several commits